get_chrome_version() Gives Wrong Major Version

[Speedup-code]

Good afternoon.

I am using Windows 10. It appears that when a new major version of chrome is released and automatically downloaded in the background, your program does not work until Chrome is fully updated.

Running chromedriver_autoinstaller.get_chrome_version() gives the new major version that is not actually fully installed and therefore downloads a newer chromedriver that is not actually compatible with Chrome. This problem has occurred for me previously but today with the release of Chrome 131 I was able to analyze it.

In the code I see that you are determining the version by the highest downloaded version in the /Chrome/Application directory. In my case there is both "130.0.6723.117" and "131.0.6778.69"

dirs = [f.name for f in os.scandir(path) if f.is_dir() and re.match("^[0-9.]+$", f.name)] if path else None
version = max(dirs) if dirs else None

I guess you'd need a more robust way to check which version of chrome is currently being used.

The workaround I have been using (aside from updating Chrome fully) is to catch the SessionNotCreatedException and use the chromedriver that was downloaded for the version prior (get_chrome_version() - 1).

Aside from this I have had no problems, thank you for this release.

[Speedup-code]

win32com.client Dispatch seems to be able to get the current version of the chrome.exe file. I'm sure there are problems with this but it would solve this issue at least (that no one else seems to have).

[shawnCaza]

Thanks @Speedup-code for analyzing the situation. Would you be interested in submitting a pr?

[Speedup-code]

I'm new to Github and I don't really know what I'm doing. This is essentially the code I'd add to the 'elif platform == "win":' of get_chrome_version()

from win32com.client import Dispatch

  if dirs:
      if len(dirs) == 1:
          version = dirs[0]
      else:
          parser = Dispatch("Scripting.FileSystemObject")
          version = parser.GetFileVersion(os.path.join(path, "chrome.exe"))
  else:
      version = None

I'm not good enough at Python to compress it more than this. I put it so it only uses the Dispatch when there's more than 1 version folder but I'm not sure if this is preferable. I guess this is not a very common problems since it hasn't been addressed previously.

[shawnCaza]

@Speedup-code if you did want to add a pull request there is a quick run down of how here.