fun onDestroy() of InstanceKeeper.Instance not called

[Petrulak]

Hello, i am playing with your library , its great , but i have run into an issue that the onDestroy() of InstanceKeeper.Instance is not called when i pop a screen.
Here is my code.

// inside of a composable fun
val viewModel = rememberOnRoute(SettingsViewModel::class) { savedState -> SettingsViewModel(savedState) }

class SettingsViewModel(private val context: RouterContext) : InstanceKeeper.Instance {

  init {
    Logger.e("init")
    context.lifecycle.subscribe(object : Lifecycle.Callbacks {
      override fun onCreate() {
        Logger.e("onCreate")
        super.onCreate()
      }

      override fun onDestroy() {
        Logger.e("onDestroy")
       //  this@SettingsViewModel.onDestroy() ->i can call onDestroy directly, but this feels hacky
        super.onDestroy()
      }

      override fun onPause() {
        super.onPause()
      }

      override fun onResume() {
        super.onResume()
      }

      override fun onStart() {
        Logger.e("onStart")
        super.onStart()
      }

      override fun onStop() {
        Logger.e("onStop")
        super.onStop()
      }
    }
    )
  }

  // NOT CALLED WHEN i POP THE SCREEN
  override fun onDestroy() {
    Logger.e("MAIN onDestroy")
    super.onDestroy()
  }

}

Can you maybe guide me on what i have done wrong ?

Thanks

[Petrulak]

I have just checked the NYTimes repo,
StoryViewModel.kt
https://github.com/xxfast/NYTimes-KMP/blob/main/app/src/commonMain/kotlin/io/github/xxfast/nytimes/screens/story/StoryViewModel.kt
And it is pretty much the same behaviour , onDestoroy is not being triggered then the screen is popped.

[xxfast]

Hi, thanks for opening the issue.

This is because rememberOnRoute doesn't directly expose that Instance object to the use-site.

I've made an API change to allow this (without enforcing an inheritance hierarchy) in the latest #104. The RouterContext (which provides a Lifecycle) is now the receiver for rememberOnRoute which should let you do this to achieve your desired behaviour

val viewModel: DetailsViewModel = rememberOnRoute { // this: RouterContext
    val viewModel = DetailsViewModel(this, item)
    this.doOnDestroy { viewModel.cancel() }
    return@rememberOnRoute viewModel
  }

I've also updated the list-detail screens to demonstrate this use case in the app

[xxfast]

This is ready for test in 0.9.0-SNAPSHOT. Added some test cases to test for this and shiny new docs to cover this case here

[Petrulak]

@xxfast perfect, thanks! :)