Skip to content

Suggest Reforges / Gem Summary suggests unnecessary gem swaps. #1316

@bp2008

Description

@bp2008

Describe the bug
Gem Summary suggests unnecessary gem swaps which have no effect on the final stats of the build.

To Reproduce
Steps to reproduce the behavior:

  1. Load this setup: https://www.wowsims.com/mop/druid/balance/#eJyrYOISy2AsYJzAyHiAkfECI2MDE+MEJpYZTExOTA6MQgxSn9lnMbMF5CRWphZxcApwS71h5OITOPeJVYnt8wvWmddZNEq42AV2fmHV6GLk4heY+IJV4piqEtuXayyzr7MAVT79yCoxR02JGShgwcQlLDAfyD+sBFaw8hpQM1CQR2DlF1aJfUpKjAxAwwQEzn5ilTinpMTy5xoLg8ZykHWXnrOCdYCsKwXa0g+0Zb6aEhvQinnXWIBaJh1mlTilpMQ8+zrESG6ByUB7OpQ0SoEcAYFnYI4SM9BEsAinwMwVrBozGIFMNoH2laxAWkRgIlDRLaDL5oGdrtEJkmVQEuDYe4lFAIgltl5iMZh1nEVrB5MEE9cGRoYhBoQaBtzJVreBIYofCo2GLrnAiSGJTYqFCxjEu5jYjAyNjYyNDzFJcJzdzyRwaj+TxJInTApHLjFpbLnEZHBkP9MJJuYLTNy3mBgeMTFJML5gSmlkhhhj4tDFzKC0gsmDiRPMP1DkIAiR8XOQnDUTBE7aW0JELtgrpoHBNfvAs2dA4I69I4Txxt7oCWPBqs+MVdxBiZkpCiGJRempJQqxEuxadIrdgBYHYpQdcLiBrM7HYu4cR3Q1YO8+OKHgOJMREgI37WFqHADNaqPC
  2. Change reforge optimizer settings to include gems:
Image Image
  1. Click 'Suggest Reforges'. The Gem Summary swaps a lot of gems with exactly no difference to the resulting stats. All of the recommended gem changes cancel each other out.

Expected behavior
Wowsims should compute the minimal required gem replacements to reach the target stats, not recommend swaps that cancel each other out.

Sim Links and Screenshots

Here's another example where wowsims suggests 6 gem swaps, but upon simple analysis you can see that two of the gem swaps were completely unnecessary as they cancel each other out:

https://www.wowsims.com/mop/druid/balance/#eJyrYOISy2AsYJzAyHiAkfECI2MDE+MEJpYZTExOTA6MQgxSn9lnMbMF5CRWphZxcApwS71h5OITOPeJVYnt8wvWmddZNEq42AV2fmHV6GLk4heY+IJV4piqEtuXayyzr7MAVT79yCoxR02JGShgwcQlLDAfyD+sBFaw8hpQM1CQR2DlF1aJfUpKjAxAwwQEzn5ilTinpMTy5xoLg8ZykHWXnrOCdYCsKwXa0g+0Zb6aEhuQP+8aC1DLpMOsEqeUlJjB7gEayS0wGWhPh5JGKZAjIPAMzAE7AizCKTBzBavGDEYgk02gfSUrkBYRmAhUdAvosnkQezpBsgxKAhx7L7EIALHE1kssBrOOs2jtYJJg4trAyDDEgFDDgDvZ6jYwRPFDodHQJRc4MSSxSbFwAYN4FxObkaGxkbHxISYJjrP7mQRO7WeSWPKESeHIJSaNLZeYDI7sZzrBxHyBifsWE8MjJiYJxhdMKY3MEGNMHLqYGZRWMHkwcYL5B4ocBCEyfg6Ss2aCwEl7S4jIBXvFNDC4Zh949gwI3LF3hDDe2Bs9YSxY9ZmxijsoMTNFISSxKD21RCFWgl2LTrEb0OJAjLIDDjeQ1flYzJ3jiK4G7N0HJxQcZzJCQuCmPUyNAwCQhKO0

If you suggest reforges on the above build, including gems, it comes up with 6 gem swaps. Two of them just cancel each other out.

Image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome Version 144

Additional context
Following wowsims gemming advice to the letter is very wasteful; usually I am able to manually determine a more efficient set of gem swaps that get me to the recommended stats.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions