Ruby 4 support

[faisal]

Ruby 4 is here. Are we?

bundle exec rake test
...
  1) Error:
RubyCritic::Generator::HtmlReport::#generate_report::when base branch does not contain the compared file#test_0001_still works:
NoMethodError: undefined method 'path' for an instance of FakeFS::Pathname
    .bundle/ruby/4.0.0/gems/reek-6.5.0/lib/reek/configuration/app_configuration.rb:70:in 'Pathname#=='
    .bundle/ruby/4.0.0/gems/reek-6.5.0/lib/reek/configuration/app_configuration.rb:70:in 'Array#include?'
    .bundle/ruby/4.0.0/gems/reek-6.5.0/lib/reek/configuration/app_configuration.rb:70:in 'Reek::Configuration::AppConfiguration#path_excluded?'
    lib/rubycritic/analysers/smells/reek.rb:13:in 'block in RubyCritic::Analyser::ReekSmells#initialize'
    lib/rubycritic/core/analysed_modules_collection.rb:32:in 'Array#each'
    lib/rubycritic/core/analysed_modules_collection.rb:32:in 'RubyCritic::AnalysedModulesCollection#each'
    lib/rubycritic/analysers/smells/reek.rb:13:in 'Enumerable#reject'
    lib/rubycritic/analysers/smells/reek.rb:13:in 'RubyCritic::Analyser::ReekSmells#initialize'
    lib/rubycritic/analysers_runner.rb:30:in 'block in RubyCritic::AnalysersRunner#run'
    lib/rubycritic/analysers_runner.rb:29:in 'Array#each'
    lib/rubycritic/analysers_runner.rb:29:in 'RubyCritic::AnalysersRunner#run'
    test/lib/rubycritic/generators/html_report_test.rb:37:in 'create_analysed_modules_collection'
    test/lib/rubycritic/generators/html_report_test.rb:19:in 'block (4 levels) in <top (required)>'

164 runs, 290 assertions, 0 failures, 1 errors, 0 skips
rake aborted!
Command failed with status (1)
/Users/faisal/Documents/Versioned/rubycritic/.bundle/ruby/4.0.0/gems/rake-13.3.1/exe/rake:27:in '<top (required)>'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/cli/exec.rb:61:in 'Kernel.load'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/cli/exec.rb:61:in 'Bundler::CLI::Exec#kernel_load'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/cli/exec.rb:24:in 'Bundler::CLI::Exec#run'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/cli.rb:500:in 'Bundler::CLI#exec'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/vendor/thor/lib/thor/command.rb:28:in 'Bundler::Thor::Command#run'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in 'Bundler::Thor::Invocation#invoke_command'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/vendor/thor/lib/thor.rb:538:in 'Bundler::Thor.dispatch'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/cli.rb:35:in 'Bundler::CLI.dispatch'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/vendor/thor/lib/thor/base.rb:584:in 'Bundler::Thor::Base::ClassMethods#start'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/cli.rb:29:in 'Bundler::CLI.start'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/exe/bundle:28:in 'block in <top (required)>'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/lib/bundler/friendly_errors.rb:118:in 'Bundler.with_friendly_errors'
/Users/faisal/.gem/ruby/4.0.0/gems/bundler-4.0.3/exe/bundle:20:in '<top (required)>'
/Users/faisal/.gem/ruby/4.0.0/bin/bundle:25:in '<main>'
Tasks: TOP => test
(See full trace by running task with --trace)

[etagwerker]

@faisal #556 should fix this issue.

I did have to add a monkeypatch to FakeFS. Not sure if this is something that needs to be properly patched in fakefs or reek so I submitted this issue: fakefs/fakefs#526

[grosser]

fakefs v3.1.0 has a fix

[faisal]

fakefs v3.1.0 has a fix

Difficulty:

$ bundle update
Fetching gem metadata from https://rubygems.org/.......
Resolving dependencies...
Could not find compatible versions

Because fakefs >= 3.0.2 depends on Ruby >= 3.2.0
  and Gemfile depends on fakefs ~> 3.1.0,
  Ruby >= 3.2.0 is required.
So, because current Ruby version is = 3.1.7,
  version solving has failed.

@etagwerker is it worth finally ending Ruby 3.1 support in order to move forward here?

FWIW, it looks like fakefs 3.2.0 will let us drop the irb dependency, so if we do kill Ruby 3.1 support I think it's worth moving to 3.2.0 and cutting the irb line.

[grosser]

3.1 is EOL anyways, so no reason to keep it around afaik

[faisal]

The current version of Rubycritic doesn't work on 3.1 or any other Ruby, given the way we use Flog:

~/Documents/Versioned/faisal.com: (main) $ ruby -v
ruby 3.1.7p261 (2025-03-26 revision 0a3704f218) [arm64-darwin25]
~/Documents/Versioned/faisal.com: (main) $ rubycritic --version
RubyCritic 4.11.0

~/Documents/Versioned/faisal.com: (main) $ rubycritic --version 
RubyCritic 4.11.0

~/Documents/Versioned/faisal.com: (main) $ rubycritic          
/Users/faisal/.gem/ruby/3.1.7/gems/flog-4.9.1/lib/flog.rb:7: warning: already initialized constant NotRubyParser
/Users/faisal/.gem/ruby/3.1.7/gems/flay-2.14.1/lib/flay.rb:11: warning: previous definition of NotRubyParser was here
running flay smells

/Users/faisal/.gem/ruby/3.1.7/gems/flog-4.9.1/lib/flog.rb:237:in `initialize': can't modify frozen Hash: {:all=>true, :continue=>true, :methods=>true} (FrozenError)
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/analysers/helpers/flog.rb:14:in `initialize'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/analysers/smells/flog.rb:16:in `new'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/analysers/smells/flog.rb:16:in `initialize'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/analysers_runner.rb:30:in `new'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/analysers_runner.rb:30:in `block in run'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/analysers_runner.rb:29:in `each'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/analysers_runner.rb:29:in `run'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/commands/default.rb:24:in `critique'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/commands/default.rb:19:in `execute'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/lib/rubycritic/cli/application.rb:21:in `execute'
	from /Users/faisal/.gem/ruby/3.1.7/gems/rubycritic-4.11.0/bin/rubycritic:10:in `<top (required)>'
	from /Users/faisal/.gem/ruby/3.1.7/bin/rubycritic:25:in `load'
	from /Users/faisal/.gem/ruby/3.1.7/bin/rubycritic:25:in `<main>'

The fix for that is in 64e8a23, but we haven't done a release since then.

If we're going to drop Ruby 3.1 support I suggest we cut a fixed backward-compatibility release off a branch of 64e8a23, then release a new version that drops Ruby 3.1 support based on what's currently in main plus today's flurry of PRs. Maybe 4.12 for the fix and 5.0 for the path forward?