Skip to content
This repository was archived by the owner on Jan 16, 2020. It is now read-only.
This repository was archived by the owner on Jan 16, 2020. It is now read-only.

Folder versioning params assume a specific order #37

@brwyatt

Description

@brwyatt

The Augeas changes file assumes that the param nodes in the versioning node will always have the same order. This assumption has lead to incorrect setting of the params such that there are duplicate param nodes with the same key attribute, but different values.

         <versioning type="staggered">
             <param key="maxAge" val="31104000"></param>
             <param key="cleanInterval" val="3600"></param>
             <param key="maxAge" val="2592000"></param>
         </versioning>

In this case, the first "maxAge" param was added by the module, but the second one is the one which takes effect. Additionally, "cleanInterval" does not apply to staggered versioning (this was left over from manual configuration, so this being left over is not unique to this module, Syncthing is doing it, too).

The module should either edit the existing param node for the key, or remove all nodes that aren't managed (since there are only a handful of possible keys for each versioning type, it should be possible to do the full managed route if good defaults are used if not defined).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions