From 14950970a605adc6a89a41835474731fa443c3c8 Mon Sep 17 00:00:00 2001 From: Markus Hesper Date: Thu, 4 Sep 2025 20:58:06 +0200 Subject: [PATCH] fix(ejs): refine check for already defined props as this was running into false positives --- src/BaseElement.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/BaseElement.js b/src/BaseElement.js index b2f18c3..6ec8c46 100644 --- a/src/BaseElement.js +++ b/src/BaseElement.js @@ -337,8 +337,9 @@ class BaseElement extends HTMLElement { this._state[property].subscribe(this); } - if (Object.getOwnPropertyDescriptor(this, property)) { - // instance already has a defined property + const descriptor = Object.getOwnPropertyDescriptor(this, property); + if (descriptor && descriptor.set && descriptor.get) { + // instance already has a defined, reactive ejs property return; } Object.defineProperty(this, property, {