serialise-javascript outdated!

[erisnuts]

Description

Hello, please, could you update serialise-javascript library asap?

https://github.com/yahoo/serialize-javascript/releases/tag/v7.0.1

[evenstensberg]

Send a pr

[askoufis]

I'm happy to make a PR for this, however v7 dropped support for Node<20, which doesn't align with this plugin's supported node versions (>=10.13.0).

[alexander-akait]

@okuryu hello, can you backport security fix to serialize-javascript@6 we have a lot of repos which uses 6 version and currently can't update it (but it is in our roadmap), thanks

[okuryu]

serialize-javascript v6.x is actually intended for use with Node.js 18 or higher. Is that okay?
https://github.com/yahoo/serialize-javascript/blob/v6.0.2/.github/workflows/test.yml#L14
I might be able to backport security fixes to serialize-javascript v6.x on my end, but if you have a requirement to support Node.js 10.x or higher, this may not be appropriate.

(Generally, many npm packages operate under the principle of supporting LTS Node.js versions. Personally, I don't have a good impression of being forced to support older Node.js versions.)

[alexander-akait]

@okuryu I see... that is an interesting problem we have a lot of CI tests for Node@10+ and serialize-javascript@6 works fine, maybe we can remove the engines in such because, because code works fine with node@10, I often feel that using engines without actually using the new features it brings more problems in the update than improvements, but that's my opinion, but it will be enough for us to just port security fixes, because serialize-javascript@6 works fine with Node@10, we don't need here new features, just security fixes