Consistent Error Responses

[Jehfkemsy]

Is your feature request related to a problem? Please describe.
I can't provide concise error messages on the front-end.
I'm not sure what responses to expect from the API other than success or failure...let's establish a convention

Describe the solution you'd like

• Route
  • Failed?
    - Stop at 1st encountered error
    - return What went wrong in ~3 words?
  • success?
  • return success

Reminder: keep response.data schema consistent

• Faillure
  { ... data: { success: boolean, error: string } ... }

• Success
  { ... /*where any is the type of the expected response value...*/ data: { success: boolean, data: any } ... }

Targeting routes
- create
- read
- readOne
- update
- confirm
- apply
- unconfirm
- login
- forgotPassword
- resetPassword
- checkIn
- accept
- remindApply
- emailConfirmation
- remindConfirm
- resend

Additional context

• Consider creating an object of common errors which will help to stay consistent and prevent typos from breaking the server

• Consider looking into this http-errors
  seems pretty helpful

[mrmcpowned]

Another thing I noticed is that the frontend isn't wired where so react components have access to the response object from the server, so that's another thing we'll need to account for when having consistent/verbose errors.

[mrmcpowned]

Also, error messages should be more verbose. If a user enters incorrect credentials, we should respond with Incorrect password rather than Wrong login info.

We also shouldn't be grouping errors together, since right now sending an incorrect email or an incorrect password both end up with Wrong login info when the errors should be Account does not exist and Incorrect Password respectively. These changes would help a lot with debugging especially in terms of finding out where the issue may have occurred.