R2/C2 resetting memory to firmware defaults using Z Offset Wizard

[WheresWaldo]

READ THE FOLLOWING FIRST:

There are 2 templates below: 'Bug Report' and 'Feature Request'. Use the one which relates most to your issue. All information enclosed in [brackets] are tips and removing them makes your ticket more readable.

---

Bug Report

What did you do?

Perform Z Offset Wizard

What did you expect to happen?

All settings in EEPROM should have been preserved

What happened instead?

All settings are rest to firmware defaults

What version of RoboOS are you using?

1.10.1

Link copy of octoprint.log or paste raw lines:

NOT an OctoPrint issue
[gist.github.com or pastebin.com are resources to save and share documents]

Screenshot(s) or video(s) showing the problem:

[WheresWaldo]

This is just poor programming practice and invalidates anything you may or may not set to permanently be used by Marlin in any Robo R2/C2 printer. Why would anyone think that dumping all user set variables on running a Z Offset wizard is a good thing? Things like PID tuning, Offsets, among other variables are overwritten with firmware not user defaults.

[AllenMcAfee]

@WheresWaldo in the old version of RoboLCD we did indeed include an M502 command in the Z Offset wizard to account for users who started the Wizard, but backed out. In the way the Wizard handled the M206 value in earlier versions, backing out of the wizard would cause issues with the value that was saved, so M502 was a blanket-like approach to handle these situations.

In hind sight it obviously created issues with user saved variables. This has been fixed in the latest release that will be going public after external testing. Now, the only place M502 is used is the Reset option on the EEPROM screen, at the bottom.