Support date without time

[Rubenfer]

Vapor 4 cannot decode dates.

Steps to reproduce

1. Create an empty project using vapor-beta toolbox and using a SQLite database for testing purposes.

2. Open Todo.swift file and add a field to store a date

Todo model file looks:

import Fluent
import Vapor

final class Todo: Model, Content {
    static let schema = "todos"
    
    @ID(key: .id)
    var id: UUID?

    @Field(key: "title")
    var title: String
    
    @Field(key: "date")
    var date: Date

    init() { }

    init(id: UUID? = nil, title: String, date: Date) {
        self.id = id
        self.title = title
        self.date = date
    }
}

3. Configure the field on the migration file.

import Fluent

struct CreateTodo: Migration {
    func prepare(on database: Database) -> EventLoopFuture<Void> {
        return database.schema("todos")
            .id()
            .field("title", .string, .required)
            .field("date", .date, .required)
            .create()
    }

    func revert(on database: Database) -> EventLoopFuture<Void> {
        return database.schema("todos").delete()
    }
}

4. Run the migrations.

5. Create a new Todo with ISO8601 date.

6. Try to get the todos. It fails.

Expected behavior

The list of todos is returned.

Actual behavior

[ ERROR ] invalid field: date type: Date error: Decoding error: Value of type 'Date' required for key ''.

Environment

• Vapor Framework version: 4.0.0-rc.3.12
• Fluent Framework version: 4.0.0-rc.1
• Fluent-kit Framework version: 4.0.0-rc.1.16
• Fluent-sqlite-driver Framework version: 4.0.0-rc.1.1
• OS version: macOS 10.15.4

[0xTim]

Looks like an SQLite error, this works fine with Postgres

[Rubenfer]

Yes, I have other projects with Postgres and it works, but today I've tried in a SQLite project just for a quick test and it fails. This is not a critial bug for productions environmets but good to know.

[0xTim]

As a temporary workaround, if you change the migration type to .datetime, this then works

[tanner0101]

SQLite currently only supports storing Date in the .datetime data type. I've updated this issue to be a feature request for date without time support.

[golaughlin]

I'm getting a similar issue with using the Date data type. This time I get a "Value was not of type 'Date' at path 'dayofBirth'. Could not decode property. Underlying error: valueNotFound(Foundation.Date, Swift.DecodingError.Context(codingPath: [SomeCodingKey(stringValue: \"dayofBirth\", intValue: nil)], debugDescription: \"Cannot get value of type Date -- found null value instead\", underlyingError: nil))." error when I attempt to post JSON.

The JSON I'm trying to POST:

{
  "firstName": "Charlie",
  "lastName": "Swift",
  "dayOfBirth": "2019-06-02T00:00:00Z",
  "hometown": "Metropolis",
  "isNaughty": false
}

The Model and Migration code

final class Child: Model, @unchecked Sendable, Content {
    static let schema = "children"
    
    @ID(key: .id)
    var id: UUID?

    @Field(key: "firstName")
    var firstName: String

    @Field(key: "lastName")
    var lastName: String

    @Field(key: "dayOfBirth")
    var dayofBirth: Date

    @Field(key: "hometown")
    var hometown: String

    @Field(key: "isNaughty")
    var isNaughty: Bool

    init() { }

    init(id: UUID? = nil, firstName: String, lastName: String, dayOfBirth: Date, hometown: String, isNaughty: Bool) {
        self.id = id
        self.firstName = firstName
        self.lastName = lastName
        self.dayofBirth = dayOfBirth
        self.hometown = hometown
        self.isNaughty = isNaughty
    }
}

struct CreateChild: AsyncMigration {
    func prepare(on database: any Database) async throws {
        try await database.schema("children")
            .id()
            .field("firstName", .string, .required)
            .field("lastName", .string, .required)
            .field("dayOfBirth", .datetime, .required)
            .field("hometown", .string, .required)
            .field("isNaughty", .bool, .required)
            .create()
    }

    func revert(on database: any Database) async throws {
        try await database.schema("children").delete()
    }
}

[0xTim]

@golaughlin this looks like an encoding issue not related to SQLite. The best place to ask is Discord

[golaughlin]

Just did.