From 6107471800bec201ed70c716ff2e5fb5ed60b93b Mon Sep 17 00:00:00 2001 From: v-zhocai Date: Tue, 2 Sep 2025 15:20:19 +0800 Subject: [PATCH 1/2] add waitfor on locator --- src/common/commonSteps.ts | 10 +--------- src/common/utils.ts | 7 +------ 2 files changed, 2 insertions(+), 15 deletions(-) diff --git a/src/common/commonSteps.ts b/src/common/commonSteps.ts index 22f047f..752d9cf 100644 --- a/src/common/commonSteps.ts +++ b/src/common/commonSteps.ts @@ -256,16 +256,8 @@ async function installExtensionForCommand(page: Page, extensionDir: string) { process.env.VSIX_PATH || path.resolve(__dirname, "../../extension.vsix") await sleep(5) await page.keyboard.press("Control+Backquote") + await page.getByRole("textbox", { name: /Terminal/ }).first().waitFor({ state: 'visible', timeout: 10000 }) await screenShot.screenShot("open_terminal.png") - await retry( - 10, - async () => { - const cmd = page.getByRole("textbox", { name: /Terminal/ }).first() - return (await cmd.count()) > 0 - }, - "Failed to find command palette", - 3 - ) const cmd = page.getByRole("textbox", { name: /Terminal/ }).first() await cmd.click() await sleep(2) diff --git a/src/common/utils.ts b/src/common/utils.ts index 9cd202c..ae78e44 100644 --- a/src/common/utils.ts +++ b/src/common/utils.ts @@ -66,6 +66,7 @@ const test = baseTest.extend<{ ].filter((v): v is string => !!v), }) const page = await app.firstWindow() + await page.getByText('File', { exact: true }).waitFor({ state: 'visible', timeout: 10000 }) const userSettingsPath = path.join( tempDir, "user-data", @@ -83,12 +84,6 @@ const test = baseTest.extend<{ ], }) ) - // spawn("code", [ - // "--install-extension", - // path.resolve(__dirname, "../../extension.vsix"), - // "--extensions-dir", - // path.resolve(tempDir, "extensions"), - // ]) return { page, extensionDir: path.join(tempDir, "extensions") } }) From 97a1ebd1f142cd42c367bbfc1a7bcdd206cd430d Mon Sep 17 00:00:00 2001 From: v-zhocai Date: Tue, 2 Sep 2025 16:44:24 +0800 Subject: [PATCH 2/2] delete unused waitfor --- src/common/utils.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/common/utils.ts b/src/common/utils.ts index ae78e44..a9100fe 100644 --- a/src/common/utils.ts +++ b/src/common/utils.ts @@ -66,7 +66,6 @@ const test = baseTest.extend<{ ].filter((v): v is string => !!v), }) const page = await app.firstWindow() - await page.getByText('File', { exact: true }).waitFor({ state: 'visible', timeout: 10000 }) const userSettingsPath = path.join( tempDir, "user-data",