From dd45041a044239d80a1c2ba233a7b200e3de4ad9 Mon Sep 17 00:00:00 2001 From: fogelito Date: Thu, 10 Jul 2025 09:27:08 +0300 Subject: [PATCH 1/3] Test update documents boolean default --- src/Database/Database.php | 3 +++ tests/e2e/Adapter/Scopes/DocumentTests.php | 16 +++++++++++++++- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git a/src/Database/Database.php b/src/Database/Database.php index 0658065cc..fc6337b6d 100644 --- a/src/Database/Database.php +++ b/src/Database/Database.php @@ -4378,6 +4378,9 @@ public function updateDocuments( $updates = $this->encode($collection, $updates); + var_dump('====================='); + var_dump($updates); + // Check new document structure $validator = new PartialStructure( $collection, diff --git a/tests/e2e/Adapter/Scopes/DocumentTests.php b/tests/e2e/Adapter/Scopes/DocumentTests.php index 50bbcba57..1dff5f6c2 100644 --- a/tests/e2e/Adapter/Scopes/DocumentTests.php +++ b/tests/e2e/Adapter/Scopes/DocumentTests.php @@ -3533,6 +3533,17 @@ public function testUpdateDocuments(): void 'array' => false, 'filters' => [], ]), + new Document([ + '$id' => ID::custom('boolean'), + 'type' => Database::VAR_BOOLEAN, + 'format' => '', + 'size' => 0, + 'signed' => true, + 'required' => false, + 'default' => false, // not null + 'array' => false, + 'filters' => [], + ]), ], permissions: [ Permission::read(Role::any()), Permission::create(Role::any()), @@ -3544,7 +3555,8 @@ public function testUpdateDocuments(): void $database->createDocument($collection, new Document([ '$id' => 'doc' . $i, 'string' => 'textđź“ť ' . $i, - 'integer' => $i + 'integer' => $i, + 'boolean' => true ])); } @@ -3562,6 +3574,7 @@ public function testUpdateDocuments(): void foreach ($results as $document) { $this->assertEquals('textđź“ť updated', $document->getAttribute('string')); + $this->assertEquals(false, $document->getAttribute('boolean')); } $updatedDocuments = $database->find($collection, [ @@ -3573,6 +3586,7 @@ public function testUpdateDocuments(): void foreach ($updatedDocuments as $document) { $this->assertEquals('textđź“ť updated', $document->getAttribute('string')); $this->assertGreaterThanOrEqual(5, $document->getAttribute('integer')); + $this->assertEquals(true, $document->getAttribute('boolean')); } $controlDocuments = $database->find($collection, [ From b26e25ae41e8618229461b9119d40602907b0e58 Mon Sep 17 00:00:00 2001 From: fogelito Date: Thu, 10 Jul 2025 09:35:15 +0300 Subject: [PATCH 2/3] Default null --- tests/e2e/Adapter/Scopes/DocumentTests.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/e2e/Adapter/Scopes/DocumentTests.php b/tests/e2e/Adapter/Scopes/DocumentTests.php index 1dff5f6c2..e5c268f60 100644 --- a/tests/e2e/Adapter/Scopes/DocumentTests.php +++ b/tests/e2e/Adapter/Scopes/DocumentTests.php @@ -3574,7 +3574,7 @@ public function testUpdateDocuments(): void foreach ($results as $document) { $this->assertEquals('textđź“ť updated', $document->getAttribute('string')); - $this->assertEquals(false, $document->getAttribute('boolean')); + $this->assertEquals(true, $document->getAttribute('boolean')); } $updatedDocuments = $database->find($collection, [ From 157f0cd42a2bd08324855f16543e5165668baf53 Mon Sep 17 00:00:00 2001 From: fogelito Date: Thu, 10 Jul 2025 09:47:04 +0300 Subject: [PATCH 3/3] Remove var_dumps --- src/Database/Database.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/Database/Database.php b/src/Database/Database.php index fc6337b6d..0658065cc 100644 --- a/src/Database/Database.php +++ b/src/Database/Database.php @@ -4378,9 +4378,6 @@ public function updateDocuments( $updates = $this->encode($collection, $updates); - var_dump('====================='); - var_dump($updates); - // Check new document structure $validator = new PartialStructure( $collection,