cmake build system lacks optimization settings

[SamuelTrahanNOAA]

The optimization settings in the Makefile are absent from the CMake-based build system. This will lead to different performance. @guoqing-noaa alerted me to this problem.

From Makefile:

intel:   # BUILDTARGET Intel oneAPI Fortran, C, and C++ compiler suite
        ( $(MAKE) all \
        "FC_PARALLEL = mpifort" \
        "CC_PARALLEL = mpicc" \
        "CXX_PARALLEL = mpic++" \
        "FC_SERIAL = ifx" \
        "CC_SERIAL = icx" \
        "CXX_SERIAL = icpx" \
        "FFLAGS_PROMOTION = -real-size 64" \
        "FFLAGS_OPT = -O3 -convert big_endian -free -align array64byte" \
        "CFLAGS_OPT = -O3" \
        "CXXFLAGS_OPT = -O3" \
        "LDFLAGS_OPT = -O3" \
        "FFLAGS_DEBUG = -g -convert big_endian -free -check bounds,pointers,arg_temp_created,format,shape,contiguous -fpe0 -traceback" \
        "CFLAGS_DEBUG = -g -traceback" \
        "CXXFLAGS_DEBUG = -g -traceback" \
        "LDFLAGS_DEBUG = -g -traceback" \
        "FFLAGS_OMP = -qopenmp" \
        "CFLAGS_OMP = -qopenmp" \
        "PICFLAG = -fpic" \
        "BUILD_TARGET = $(@)" \
        "CORE = $(CORE)" \
        "DEBUG = $(DEBUG)" \
        "USE_PAPI = $(USE_PAPI)" \
        "OPENMP = $(OPENMP)" \
        "CPPFLAGS = $(MODEL_FORMULATION) -D_MPI" )

I can't find the -O3 -convert big_endian -free -align array64byte anywhere in the CMake-based build system.

[clark-evans]

Just confirming that #175 would not address this issue, but rather the follow-up PR that Guoqing referenced in #175 is needed to address this issue?

[SamuelTrahanNOAA]

PR #175 won't address this issue. It also won't get double-precision reals working in the cmake build system. (I don't think anyone has submitted an issue for that problem yet.)

[SamuelTrahanNOAA]

I've opened these Issues to describe other bugs in the cmake build system:

• cmake build system double precision support is inconsistent or broken #181
• cmake build system requires all I/O format options, even ones that aren't needed #182

Those two, and this, describe the bugs I know of in the cmake build system as it is of the moment of this comment posting.