Skip to content
This repository was archived by the owner on Jan 20, 2022. It is now read-only.
This repository was archived by the owner on Jan 20, 2022. It is now read-only.

Storm Store type should take Semigroup[V] #677

@johnynek

Description

@johnynek

Right now, the producer graph has a Semigroup[V] in sumByKey, but actually, the storm platform ignores it.

Scalding does not.

https://github.com/twitter/summingbird/blob/develop/summingbird-online/src/main/scala/com/twitter/summingbird/online/MergeableStoreFactory.scala

A fix for this is to have MergeableStoreFactory really be something like Semigroup[V] => Mergeable[K, V] rather than () => Mergeable[K, V].

We can be somewhat backwards compatible by giving the old methods (but marking them as deprecated) and just ignoring the Semigroup passed in.

Without something like this #562 is pretty dangerous because online is would be really easy to have a mismatch between the store semigroup and the aggregator semigroup (this is actually already pretty dangerous and not clear how we didn't address this before now).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions