From 06b5cc0016b16d3914c8c1e7c0ee4028df551203 Mon Sep 17 00:00:00 2001 From: LainLayer Date: Fri, 27 Oct 2023 11:53:49 +0300 Subject: [PATCH 1/2] Disabled warning `UnreachableCode` for the template `asOptionalParam` This warning simply does not apply to this usecase --- src/boomer.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/boomer.nim b/src/boomer.nim index a30fb11..393f3a1 100644 --- a/src/boomer.nim +++ b/src/boomer.nim @@ -209,7 +209,7 @@ proc main() = body i += 1 - template asOptionalParam(paramVar: untyped, body: untyped) = + template asOptionalParam(paramVar: untyped, body: untyped) {. warning[UnreachableCode]:off.} = let paramVar = block: var resultVal = none(string) if i + 1 <= paramCount(): From b59f1369614eb848187a85abd5b9f195659cc981 Mon Sep 17 00:00:00 2001 From: LainLayer Date: Fri, 27 Oct 2023 11:56:16 +0300 Subject: [PATCH 2/2] changed `wmName` and `wmClass` to be `cstring` in the first place so no conversion is needed --- src/boomer.nim | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/boomer.nim b/src/boomer.nim index 393f3a1..296a709 100644 --- a/src/boomer.nim +++ b/src/boomer.nim @@ -329,8 +329,8 @@ proc main() = discard XMapWindow(display, win) - var wmName = "boomer" - var wmClass = "Boomer" + var wmName: cstring = "boomer" + var wmClass: cstring = "Boomer" var hints = XClassHint(res_name: wmName, res_class: wmClass) discard XStoreName(display, win, wmName)