From 40fcff2323d5fba137463e662697dc6f7da1e887 Mon Sep 17 00:00:00 2001 From: david catalan Date: Fri, 31 Oct 2025 15:54:47 +0100 Subject: [PATCH 1/2] fix: support structure of anthropic/skills repository --- upskill | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/upskill b/upskill index 9f29e6d..854b9f6 100755 --- a/upskill +++ b/upskill @@ -126,7 +126,7 @@ process_skills_directory() { local count=0 # Count skills first while IFS= read -r -d '' skill_file; do - ((count++)) + count=$((count + 1)) done < <(find "$skills_dir" -type f -name 'SKILL.md' -print0) if [[ $count -eq 0 ]]; then @@ -244,7 +244,7 @@ list_skills() { local count=0 local -a skill_names=() while IFS='|' read -r name path description; do - ((count++)) + count=$((count + 1)) skill_names+=("$name") # Make path relative to search_dir @@ -414,7 +414,7 @@ main() { log "Installing all $total_count skills..." while IFS='|' read -r name path description; do copy_skill "$path" "$dest_skills_dir" - ((skill_count++)) + skill_count=$((skill_count + 1)) done <"$tmpfile" elif [[ ${#selected_skills[@]} -gt 0 ]]; then log "Installing ${#selected_skills[@]} selected skill(s)..." @@ -423,7 +423,7 @@ main() { while IFS='|' read -r name path description; do if [[ "$name" == "$skill_name" ]]; then copy_skill "$path" "$dest_skills_dir" - ((skill_count++)) + skill_count=$((skill_count + 1)) found=1 break fi From 8c18f3b90ca4f0a0d87311bde068395b9b97b8ce Mon Sep 17 00:00:00 2001 From: Claude Code Date: Fri, 31 Oct 2025 22:59:32 +0100 Subject: [PATCH 2/2] fix: update tests to use main branch of adobe/helix-website MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The agent-skills branch was merged into main and deleted, so the tests now use the main branch without the -b flag. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Signed-off-by: Lars Trieloff --- tests/test-upskill.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-upskill.sh b/tests/test-upskill.sh index 868d6ca..9fe4f7d 100755 --- a/tests/test-upskill.sh +++ b/tests/test-upskill.sh @@ -18,7 +18,7 @@ trap cleanup EXIT pushd "$TMP" >/dev/null echo "Running upskill (first run) ..." -"$ROOT_DIR/upskill" adobe/helix-website -b agent-skills +"$ROOT_DIR/upskill" adobe/helix-website test -d .claude/skills || { echo "FAIL: .claude/skills missing"; exit 1; } count_skills=$(find .claude/skills -name 'SKILL.md' -type f | wc -l | tr -d ' ') @@ -39,7 +39,7 @@ count_markers=$(grep -cF "$marker_start" AGENTS.md) [[ "$count_markers" == "1" ]] || { echo "FAIL: duplicate start markers on first run"; exit 1; } echo "Running upskill (second run) ..." -"$ROOT_DIR/upskill" adobe/helix-website -b agent-skills +"$ROOT_DIR/upskill" adobe/helix-website count_markers2=$(grep -cF "$marker_start" AGENTS.md) [[ "$count_markers2" == "1" ]] || { echo "FAIL: duplicate start markers after second run"; exit 1; } @@ -51,7 +51,7 @@ echo "$out" | grep -q -- "---" || { echo "FAIL: discover-skills separator missin # Test gitignore insertion with -i echo "Running upskill with -i ..." -"$ROOT_DIR/upskill" -i adobe/helix-website -b agent-skills +"$ROOT_DIR/upskill" -i adobe/helix-website test -f .gitignore || { echo "FAIL: .gitignore not created"; exit 1; } grep -qF ".claude/skills/" .gitignore || { echo "FAIL: .gitignore missing skills entry"; exit 1; } @@ -60,7 +60,7 @@ grep -qF ".agents/discover-skills" .gitignore || { echo "FAIL: .gitignore missin # Ensure idempotent block start_marker="# upskill:gitignore:start" [[ $(grep -cF "$start_marker" .gitignore) == "1" ]] || { echo "FAIL: duplicate gitignore block after first -i"; exit 1; } -"$ROOT_DIR/upskill" -i adobe/helix-website -b agent-skills +"$ROOT_DIR/upskill" -i adobe/helix-website [[ $(grep -cF "$start_marker" .gitignore) == "1" ]] || { echo "FAIL: duplicate gitignore block after second -i"; exit 1; } echo "OK"