From 5b80e96614271c5f17c425c8639eed188b5e9586 Mon Sep 17 00:00:00 2001 From: Remco Koopmans Date: Wed, 19 Mar 2025 07:52:15 +0100 Subject: [PATCH 1/2] Add java 21 as test runtime, move v8 to oracle-test --- .github/workflows/ci-cd.yml | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 557947b..48c1eb4 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -7,13 +7,13 @@ jobs: runs-on: ${{ matrix.os }} strategy: matrix: - java: [8, 11, 17] + java: [11, 17, 21] os: [ubuntu-latest, macOS-latest, windows-latest] steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - name: Set up JDK ${{ matrix.java }} - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: distribution: 'temurin' java-version: ${{ matrix.java }} @@ -24,8 +24,8 @@ jobs: test-adopt: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v3 - - uses: actions/setup-java@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-java@v4 with: distribution: 'adopt' java-version: '8' @@ -35,13 +35,18 @@ jobs: test-oracle: runs-on: ubuntu-latest + strategy: + matrix: + java: [8, 21] + os: [ubuntu-latest, macOS-latest, windows-latest] + steps: - - uses: actions/checkout@v3 - - name: 'Set up latest Oracle JDK 17' + - uses: actions/checkout@v4 + - name: 'Set up Oracle JDK' uses: oracle-actions/setup-java@v1 with: website: oracle.com - release: 17 + release: ${{ matrix.java }} - name: Cache Maven packages uses: actions/cache@v3 with: @@ -56,14 +61,14 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - java: [8, 17] + java: [11, 17, 21] os: [ubuntu-latest, macOS-latest, windows-latest] needs: - "test" - "test-adopt" steps: - - uses: actions/checkout@v3 - - uses: actions/setup-java@v3 + - uses: actions/checkout@v4 + - uses: actions/setup-java@v4 with: distribution: 'temurin' java-version: '${{ matrix.java }}' From 7f492cac3e11c9993a892207493b70c99673ec46 Mon Sep 17 00:00:00 2001 From: Remco Koopmans Date: Wed, 19 Mar 2025 08:22:42 +0100 Subject: [PATCH 2/2] Add and remove some runners for tests --- .github/workflows/ci-cd.yml | 51 ++++++++++++++++++------------------- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 48c1eb4..6f8286c 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -8,6 +8,7 @@ jobs: strategy: matrix: java: [11, 17, 21] + distribution: ["temurin", "adopt"] os: [ubuntu-latest, macOS-latest, windows-latest] steps: @@ -15,44 +16,40 @@ jobs: - name: Set up JDK ${{ matrix.java }} uses: actions/setup-java@v4 with: - distribution: 'temurin' + distribution: ${{ matrix.distribution }} java-version: ${{ matrix.java }} cache: 'maven' - name: Build with Maven run: mvn test --file pom.xml -B - test-adopt: - runs-on: ubuntu-latest + test-oracle: + runs-on: ${{ matrix.os }} + strategy: + matrix: + java: [17, 21] + distribution: ["oracle"] + os: [ubuntu-latest, macOS-latest, windows-latest] + steps: - uses: actions/checkout@v4 - - uses: actions/setup-java@v4 + - name: Set up JDK ${{ matrix.java }} + uses: actions/setup-java@v4 with: - distribution: 'adopt' - java-version: '8' + distribution: ${{ matrix.distribution }} + java-version: ${{ matrix.java }} cache: 'maven' - name: Build with Maven run: mvn test --file pom.xml -B - test-oracle: + test-java-8: runs-on: ubuntu-latest - strategy: - matrix: - java: [8, 21] - os: [ubuntu-latest, macOS-latest, windows-latest] - steps: - uses: actions/checkout@v4 - - name: 'Set up Oracle JDK' - uses: oracle-actions/setup-java@v1 - with: - website: oracle.com - release: ${{ matrix.java }} - - name: Cache Maven packages - uses: actions/cache@v3 + - uses: actions/setup-java@v4 with: - path: ~/.m2 - key: ${{ runner.os }}-m2-${{ hashFiles('**/pom.xml') }} - restore-keys: ${{ runner.os }}-m2 + distribution: 'adopt' + java-version: '8' + cache: 'maven' - name: Build with Maven run: mvn test --file pom.xml -B @@ -65,7 +62,8 @@ jobs: os: [ubuntu-latest, macOS-latest, windows-latest] needs: - "test" - - "test-adopt" + - "test-java-8" + - "test-oracle" steps: - uses: actions/checkout@v4 - uses: actions/setup-java@v4 @@ -78,11 +76,12 @@ jobs: TINIFY_KEY: ${{ secrets.TINIFY_KEY }} run: mvn -Pintegration integration-test -B - adopt-integration-test: + adopt-integration-test-java-8: if: github.event_name == 'push' runs-on: ubuntu-latest needs: - - "test-adopt" + - "test-java-8" + - "test-oracle" - "test" steps: - uses: actions/checkout@v3 @@ -110,7 +109,7 @@ jobs: startsWith(github.ref, 'refs/tags') && github.event_name == 'push' needs: - - "adopt-integration-test" + - "adopt-integration-test-java-8" - "integration-test" runs-on: "ubuntu-latest" steps: