Skip to content
This repository was archived by the owner on Mar 30, 2022. It is now read-only.
This repository was archived by the owner on Mar 30, 2022. It is now read-only.

Should button outlines be drawn in the disabledStrokeColor in the disabled state? (patch included) #57

@garethsb-ghost

Description

@garethsb-ghost

Should button outlines be drawn in the disabledStrokeColor in the disabled state? In particular, the disabled state of an unchecked HUD checkbox is hard to distinguish from an enabled one.

I've patched BGHUDButtonCell.m locally as follows:

diff /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d/Framework/BGHUDButtonCell.m /Users/garethsb/Development/binarygod-BGHUDAppKit-79a560d-patched/Framework/BGHUDButtonCell.m >diff.txt
403c403
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
510c510
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
591c591
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
891c891
<        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>        [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
916c916
<                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
961c961
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];
983c983
<                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] strokeColor] set];

---
>                    [[[[BGThemeManager keyedManager] themeForKey: self.themeKey] disabledStrokeColor] set];

Best regards,
Gareth

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions