From 9c59a15c85adb9353640bb57bae13480de51f64a Mon Sep 17 00:00:00 2001 From: David Goodwin Date: Wed, 29 Jan 2025 21:26:18 +0000 Subject: [PATCH 1/2] possible fix for #430 - memcache_set expects flags: to be an int, cannot provide null. Only option possible is perhaps MEMCACHE_COMPRESSED? --- src/Stash/Driver/Sub/Memcache.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Stash/Driver/Sub/Memcache.php b/src/Stash/Driver/Sub/Memcache.php index 30526ed4..daa68dfb 100644 --- a/src/Stash/Driver/Sub/Memcache.php +++ b/src/Stash/Driver/Sub/Memcache.php @@ -65,7 +65,7 @@ public function set($key, $value, $expire = null) return true; } - return $this->memcached->set($key, array('data' => $value, 'expiration' => $expire), null, $expire); + return $this->memcached->set($key, array('data' => $value, 'expiration' => $expire), MEMCACHE_COMPRESSED, $expire); } /** From 519a6bf87a4767e778a357db761779c8162780fd Mon Sep 17 00:00:00 2001 From: David Goodwin Date: Sat, 8 Feb 2025 10:10:49 +0000 Subject: [PATCH 2/2] use false instead of MEMCACHE_COMPRESSED, see discussion on #430 --- src/Stash/Driver/Sub/Memcache.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Stash/Driver/Sub/Memcache.php b/src/Stash/Driver/Sub/Memcache.php index daa68dfb..eef649bd 100644 --- a/src/Stash/Driver/Sub/Memcache.php +++ b/src/Stash/Driver/Sub/Memcache.php @@ -65,7 +65,7 @@ public function set($key, $value, $expire = null) return true; } - return $this->memcached->set($key, array('data' => $value, 'expiration' => $expire), MEMCACHE_COMPRESSED, $expire); + return $this->memcached->set($key, array('data' => $value, 'expiration' => $expire), false, $expire); } /**