diff --git a/CHANGELOG.md b/CHANGELOG.md index 5f3ace85..0af462de 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,12 @@ The changelog for `Superwall`. Also see the [releases](https://github.com/superwall/Superwall-Android/releases) on GitHub. + +## 2.6.9 + +## Deprecations +- Deprecated `paywallWebviewLoad_timeout` - this event was causing confusion due to it's naming, leading to it being deprecated + ## 2.6.8 ### Enhancements diff --git a/superwall/src/main/java/com/superwall/sdk/analytics/internal/trackable/TrackableSuperwallEvent.kt b/superwall/src/main/java/com/superwall/sdk/analytics/internal/trackable/TrackableSuperwallEvent.kt index 0d00fb5b..ed9c76e3 100644 --- a/superwall/src/main/java/com/superwall/sdk/analytics/internal/trackable/TrackableSuperwallEvent.kt +++ b/superwall/src/main/java/com/superwall/sdk/analytics/internal/trackable/TrackableSuperwallEvent.kt @@ -712,10 +712,6 @@ sealed class InternalSuperwallEvent( object Fallback : State() - class Timeout( - val msg: String, - ) : State() - class Complete : State() } @@ -727,11 +723,6 @@ sealed class InternalSuperwallEvent( paywallInfo, ) - is PaywallWebviewLoad.State.Timeout -> - SuperwallEvent.PaywallWebviewLoadTimeout( - paywallInfo, - ) - is PaywallWebviewLoad.State.Fail -> SuperwallEvent.PaywallWebviewLoadFail( paywallInfo, @@ -765,11 +756,6 @@ sealed class InternalSuperwallEvent( }.toTypedArray(), ) - is State.Timeout -> - mapOf( - "error_message" to state.msg, - ) - else -> mapOf() } val params = paywallInfo.eventParams() + extras diff --git a/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvent.kt b/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvent.kt index acd9b6ed..0e427cd5 100644 --- a/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvent.kt +++ b/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvent.kt @@ -327,7 +327,7 @@ sealed class SuperwallEvent { get() = "paywallWebviewLoad_complete" } - // / When the loading of a paywall's website times out. + @Deprecated("Due to confusion this event was causing we're deprecating it's usage") data class PaywallWebviewLoadTimeout( val paywallInfo: PaywallInfo, ) : SuperwallEvent() { diff --git a/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvents.kt b/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvents.kt index e0c6a3a7..71fde2ea 100644 --- a/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvents.kt +++ b/superwall/src/main/java/com/superwall/sdk/analytics/superwall/SuperwallEvents.kt @@ -34,6 +34,8 @@ enum class SuperwallEvents( PaywallWebviewLoadStart("paywallWebviewLoad_start"), PaywallWebviewLoadFail("paywallWebviewLoad_fail"), PaywallWebviewLoadComplete("paywallWebviewLoad_complete"), + + @Deprecated("Due to confusion this event was causing we're deprecating it's usage") PaywallWebviewLoadTimeout("paywallWebviewLoad_timeout"), PaywallWebviewLoadFallback("paywallWebviewLoad_fallback"), PaywallResourceLoadFail("paywallResourceLoad_fail"), diff --git a/superwall/src/test/java/com/superwall/sdk/analytics/internal/TrackingLogicTest.kt b/superwall/src/test/java/com/superwall/sdk/analytics/internal/TrackingLogicTest.kt index 1cbd9e7d..76f6d19d 100644 --- a/superwall/src/test/java/com/superwall/sdk/analytics/internal/TrackingLogicTest.kt +++ b/superwall/src/test/java/com/superwall/sdk/analytics/internal/TrackingLogicTest.kt @@ -436,30 +436,6 @@ class TrackingLogicTest { } } - @Test - fun `isNotDisabledVerboseEvent allows PaywallWebviewLoad Timeout even when verbose events disabled`() = - Given("PaywallWebviewLoad with Timeout state and verbose events disabled") { - val paywallInfo = PaywallInfo.empty() - val event = - InternalSuperwallEvent.PaywallWebviewLoad( - state = InternalSuperwallEvent.PaywallWebviewLoad.State.Timeout("timeout"), - paywallInfo = paywallInfo, - ) - - When("checking if event is not disabled verbose event") { - val result = - TrackingLogic.isNotDisabledVerboseEvent( - event, - disableVerboseEvents = true, - isSandbox = false, - ) - - Then("it should return true because Timeout events are always allowed") { - assertTrue(result) - } - } - } - // ========== canTriggerPaywall Tests ========== @Test