From bf65b9bbc6e6094ff4ba605a7f1e9ecdf01a05b2 Mon Sep 17 00:00:00 2001
From: Marc Gurt <marcgurt.developer@gmail.com>
Date: Tue, 19 Jan 2021 12:19:03 +0100
Subject: [PATCH] add resource not found (404) validation on update base
 service method

---
 src/services/Service.js | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/services/Service.js b/src/services/Service.js
index 15548e5..265c64a 100644
--- a/src/services/Service.js
+++ b/src/services/Service.js
@@ -31,7 +31,7 @@ class Service {
         .find(query)
         .skip(skip)
         .limit(limit);
-      let total = await this.model.count();
+      let total = await this.model.countDocuments();
 
       return {
         error: false,
@@ -70,6 +70,13 @@ class Service {
   async update(id, data) {
     try {
       let item = await this.model.findByIdAndUpdate(id, data, { new: true });
+      if (!item)
+        return {
+          error: true,
+          statusCode: 404,
+          message: "item not found"
+        };
+
       return {
         error: false,
         statusCode: 202,