From 581ca973791ce49b4325e30fa609ebb06d894975 Mon Sep 17 00:00:00 2001 From: Claude Date: Wed, 24 Dec 2025 21:48:09 +0000 Subject: [PATCH 1/2] Enable 6 passing todo tests Enable the following tests that now pass: - 00978_table_function_values_alias (VALUES table function with tuples) - 01258_wrong_cast_filimonov - 01352_generate_random_overflow - 02499_escaped_quote_schema_inference - 02502_bad_values_schema_inference - 02916_set_formatting --- parser/testdata/00978_table_function_values_alias/metadata.json | 2 +- parser/testdata/01258_wrong_cast_filimonov/metadata.json | 2 +- parser/testdata/01352_generate_random_overflow/metadata.json | 2 +- .../testdata/02499_escaped_quote_schema_inference/metadata.json | 2 +- parser/testdata/02502_bad_values_schema_inference/metadata.json | 2 +- parser/testdata/02916_set_formatting/metadata.json | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/parser/testdata/00978_table_function_values_alias/metadata.json b/parser/testdata/00978_table_function_values_alias/metadata.json index ef120d978..0967ef424 100644 --- a/parser/testdata/00978_table_function_values_alias/metadata.json +++ b/parser/testdata/00978_table_function_values_alias/metadata.json @@ -1 +1 @@ -{"todo": true} +{} diff --git a/parser/testdata/01258_wrong_cast_filimonov/metadata.json b/parser/testdata/01258_wrong_cast_filimonov/metadata.json index ef120d978..0967ef424 100644 --- a/parser/testdata/01258_wrong_cast_filimonov/metadata.json +++ b/parser/testdata/01258_wrong_cast_filimonov/metadata.json @@ -1 +1 @@ -{"todo": true} +{} diff --git a/parser/testdata/01352_generate_random_overflow/metadata.json b/parser/testdata/01352_generate_random_overflow/metadata.json index ef120d978..0967ef424 100644 --- a/parser/testdata/01352_generate_random_overflow/metadata.json +++ b/parser/testdata/01352_generate_random_overflow/metadata.json @@ -1 +1 @@ -{"todo": true} +{} diff --git a/parser/testdata/02499_escaped_quote_schema_inference/metadata.json b/parser/testdata/02499_escaped_quote_schema_inference/metadata.json index ef120d978..0967ef424 100644 --- a/parser/testdata/02499_escaped_quote_schema_inference/metadata.json +++ b/parser/testdata/02499_escaped_quote_schema_inference/metadata.json @@ -1 +1 @@ -{"todo": true} +{} diff --git a/parser/testdata/02502_bad_values_schema_inference/metadata.json b/parser/testdata/02502_bad_values_schema_inference/metadata.json index ef120d978..0967ef424 100644 --- a/parser/testdata/02502_bad_values_schema_inference/metadata.json +++ b/parser/testdata/02502_bad_values_schema_inference/metadata.json @@ -1 +1 @@ -{"todo": true} +{} diff --git a/parser/testdata/02916_set_formatting/metadata.json b/parser/testdata/02916_set_formatting/metadata.json index ef120d978..9e26dfeeb 100644 --- a/parser/testdata/02916_set_formatting/metadata.json +++ b/parser/testdata/02916_set_formatting/metadata.json @@ -1 +1 @@ -{"todo": true} +{} \ No newline at end of file From bd8b7f77e4c148157629255d747277dd065114b8 Mon Sep 17 00:00:00 2001 From: Claude Date: Thu, 25 Dec 2025 04:00:24 +0000 Subject: [PATCH 2/2] Auto-enable passing todo tests with -check-skipped flag Instead of just logging "PASSES NOW", the -check-skipped flag now automatically updates the metadata.json file to remove the todo flag when a test passes. This streamlines the workflow of enabling tests after parser improvements. --- parser/parser_test.go | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/parser/parser_test.go b/parser/parser_test.go index 502d03a2a..295b26ce8 100644 --- a/parser/parser_test.go +++ b/parser/parser_test.go @@ -203,8 +203,17 @@ func TestParser(t *testing.T) { } // If we get here with a todo test and -check-skipped is set, the test passes! + // Automatically remove the todo flag from metadata.json if metadata.Todo && *checkSkipped { - t.Logf("PASSES NOW - can remove todo flag from: %s", entry.Name()) + metadata.Todo = false + updatedBytes, err := json.Marshal(metadata) + if err != nil { + t.Errorf("Failed to marshal updated metadata: %v", err) + } else if err := os.WriteFile(metadataPath, append(updatedBytes, '\n'), 0644); err != nil { + t.Errorf("Failed to write updated metadata.json: %v", err) + } else { + t.Logf("ENABLED - removed todo flag from: %s", entry.Name()) + } } }) }