Replace deprecated pseudo-private API usage#8
Open
alerque wants to merge 2 commits intospiegela:masterfrom
Open
Replace deprecated pseudo-private API usage#8alerque wants to merge 2 commits intospiegela:masterfrom
alerque wants to merge 2 commits intospiegela:masterfrom
Conversation
The pseudo-private _VimuxOption function has been deprecated and an official public VimuxOption method is available. However the way defaults are handled is also changed. If you don't want to use the default value, just don't. Hard coding the prompt here seems to make more sense that even bothering to ask what the option value is.
|
@spiegela any chance of getting this PR merged? Looks like it can help with currently not working The error I'm getting with newest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pseudo-private _VimuxOption function has been deprecated and an
official public VimuxOption method is available. However the way
defaults are handled is also changed. If you don't want to use the
default value, just don't. Hard coding the prompt here seems to make
more sense that even bothering to ask what the option value is.