Skip to content

fix: radio buttons on submit page #289

@quinn-joyce

Description

@quinn-joyce

The radio buttons on the submit page must be in a radio group so that the radio buttons have a corresponding label. For more information check out Deque's page on form elements must have labels which includes instructions on how to fix the issue.

Do this by updating the _form.hbs file. The radio buttons and label can be found on lines 6 - 8. Note: make sure to keep all of the class names and other attributes the same

Suggestion:

  • Wrap the radio buttons in a <div> with the attribute role="radiogroup". Instead of this we could always wrap the radio buttons in a feildset with a legend, but with the <div role="radiogroup"> </div> we dont have to worry about any extra styles.
  • Also, instead of adding the text "Is your apprenticeship a paid opportunity?" in a <label>, we are going to treat it like a <legend>. So the final code will look something like this with the paragraph tag having an id attribute that matches the value of the aria-labelledby on the div
<div role="radiogroup" aria-labelledby="paid-opportunity">
   <p id="paid-opportunity">Is your apprenticeship a paid opportunity?</>
   <input type="radio">
   <input type="radio">
</div>

For more information on radios and radio groups checkout Deque's example

See screenshot of radio buttons on the submit page:
Apprentice_at-radio-buttons

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions