Skip to content

MWCC literals are still matched together even when the addend is different #177

@1superchip

Description

@1superchip

In some cases, literals can have addends (struct copies that generate literals). With the current implementation of https://github.com/simonlindholm/asm-differ/blob/main/diff.py#L3000, we only check if the symbol contains "@" without comparing the 2 symbols on both sides of the diff. Ideally, the addend should match between the target and current objects.

field_matches_any_symbol doesn't have the functionality to compare the left and right symbols of the diff. I am currently working on #175 and am thinking that the solution I have for that issue may evolve to replace field_matches_any_symbol.

image
decomp.me scratch: https://decomp.me/scratch/9T6B6

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions