Skip to content

Problem with rolling your own request matcher #86

@xocasdashdash

Description

@xocasdashdash

Hi!
I had to roll my own request matcher service in my firewall and I had to implement an RequestMatcherInterface (https://github.com/symfony/HttpFoundation/blob/master/RequestMatcherInterface.php).

Now because of this file: https://github.com/schmittjoh/JMSDebuggingBundle/blob/430daab75b88d78ee9e06ed2ae7811ea3da947af/Security/TraceableMap.php (line 29) is expecting the request matcher to be one of this type https://github.com/schmittjoh/JMSDebuggingBundle/blob/430daab75b88d78ee9e06ed2ae7811ea3da947af/HttpFoundation/TraceableRequestMatcher.php

I had to implement two methods that are not present on the RequestMatcherInterface.php.

Are you open to a PR that makes this method optional so it plays well with user defined Request Matcher?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions