From ca5b11eea0d82c84a893689f06939ed9ae89c558 Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:05:06 +0000 Subject: [PATCH 1/8] test(starship): binary in PATH --- test/starship/test.sh | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 test/starship/test.sh diff --git a/test/starship/test.sh b/test/starship/test.sh new file mode 100644 index 0000000..4d62fe0 --- /dev/null +++ b/test/starship/test.sh @@ -0,0 +1,9 @@ +#!/bin/bash + +set -e + +source dev-container-features-test-lib + +check "binary in path" which starship + +reportResults From c1a7f090fc2deee21ade61768766769150900822 Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:05:43 +0000 Subject: [PATCH 2/8] fix(starship): explicitly depend on common-utils feature --- src/starship/devcontainer-feature.json | 1 + 1 file changed, 1 insertion(+) diff --git a/src/starship/devcontainer-feature.json b/src/starship/devcontainer-feature.json index 1c2487e..0952702 100644 --- a/src/starship/devcontainer-feature.json +++ b/src/starship/devcontainer-feature.json @@ -3,5 +3,6 @@ "version": "0.1.5", "name": "Starship", "description": "The minimal, blazing-fast, and infinitely customizable prompt for any shell!", + "dependsOn": {"ghcr.io/devcontainers/features/common-utils:2": {}}, "postCreateCommand": "echo 'eval \"$(starship init bash)\"' >> ~/.bashrc" } From cb17ef209b2cb5060b783a2c4e0706c494d83007 Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:06:59 +0000 Subject: [PATCH 3/8] chore(starship): bump version --- src/starship/devcontainer-feature.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/starship/devcontainer-feature.json b/src/starship/devcontainer-feature.json index 0952702..76e6131 100644 --- a/src/starship/devcontainer-feature.json +++ b/src/starship/devcontainer-feature.json @@ -1,6 +1,6 @@ { "id": "starship", - "version": "0.1.5", + "version": "0.1.6", "name": "Starship", "description": "The minimal, blazing-fast, and infinitely customizable prompt for any shell!", "dependsOn": {"ghcr.io/devcontainers/features/common-utils:2": {}}, From cff7443fd35c094c7764800764af18ef4092326a Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:09:21 +0000 Subject: [PATCH 4/8] refactor(starship): use env bash instead of direct binary path --- src/starship/install.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/starship/install.sh b/src/starship/install.sh index 9c3fc49..650243f 100644 --- a/src/starship/install.sh +++ b/src/starship/install.sh @@ -1,4 +1,4 @@ -#!/bin/sh +#!/bin/env bash apt-get install -y curl curl -sS https://starship.rs/install.sh | sh -s -- -y From ac68939fba4f468e5533cb8f84f13219a08535b2 Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:12:13 +0000 Subject: [PATCH 5/8] ci: add starship feature to test matrix --- .github/workflows/test.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 3a99e75..1610ead 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -26,6 +26,7 @@ jobs: features: - rye - cypress + - starship steps: - uses: actions/checkout@v4 From 3b007c69aea7ab2e280bda0c5d961a009bc45952 Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:15:14 +0000 Subject: [PATCH 6/8] ci: add starship (debian) to test matrix --- .github/workflows/test.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml index 1610ead..8129613 100644 --- a/.github/workflows/test.yaml +++ b/.github/workflows/test.yaml @@ -45,6 +45,7 @@ jobs: - rye - cypress - playwright + - starship steps: - uses: actions/checkout@v4 From 7de26a65b98019d22b38b379341dc8b03cf5b3bb Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:30:53 +0000 Subject: [PATCH 7/8] refactor(starship): remove unnecessary curl install --- src/starship/install.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/src/starship/install.sh b/src/starship/install.sh index 650243f..ff214bb 100644 --- a/src/starship/install.sh +++ b/src/starship/install.sh @@ -1,4 +1,3 @@ #!/bin/env bash -apt-get install -y curl curl -sS https://starship.rs/install.sh | sh -s -- -y From 71aed4b4360f64217f74db1875f8931d1e51431f Mon Sep 17 00:00:00 2001 From: Ty Schlich Date: Thu, 4 Sep 2025 15:38:59 +0000 Subject: [PATCH 8/8] refactor(starship): remove unnecessary .bashrc append of starship init script --- src/starship/devcontainer-feature.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/starship/devcontainer-feature.json b/src/starship/devcontainer-feature.json index 76e6131..135727c 100644 --- a/src/starship/devcontainer-feature.json +++ b/src/starship/devcontainer-feature.json @@ -3,6 +3,5 @@ "version": "0.1.6", "name": "Starship", "description": "The minimal, blazing-fast, and infinitely customizable prompt for any shell!", - "dependsOn": {"ghcr.io/devcontainers/features/common-utils:2": {}}, - "postCreateCommand": "echo 'eval \"$(starship init bash)\"' >> ~/.bashrc" + "dependsOn": {"ghcr.io/devcontainers/features/common-utils:2": {}} }