From 9e2899e1a9f15a7133e3a01b8714bd9ed9aac0e4 Mon Sep 17 00:00:00 2001 From: Abdul Rahim Khan <48161465+A-R-Khan@users.noreply.github.com> Date: Fri, 24 Sep 2021 06:26:03 +0530 Subject: [PATCH] Update CMakeLists.txt to not use genmsg The beginner tutorial for this repo was using a dependency on genmsg instead of message_generation which causes a lot of confusion as the tutorial for msg files, for actionlib and the docs for CMakeLists.txt say to use message_generation and not genmsg add_dependencies macro was using an explicit {project_name}_generated_messages_cpp dependency whereas the CMakeLists.txt documentation specifies to use ${catkin_EXPORTED_TARGETS}, which also causes confusion right in the beginning This problem has been raised in the ROS QA forum many times and is still not being changed Thank You --- .../catkin_ws/src/beginner_tutorials/CMakeLists.txt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/create_package_pubsub/catkin_ws/src/beginner_tutorials/CMakeLists.txt b/create_package_pubsub/catkin_ws/src/beginner_tutorials/CMakeLists.txt index 6f61633..8536de0 100644 --- a/create_package_pubsub/catkin_ws/src/beginner_tutorials/CMakeLists.txt +++ b/create_package_pubsub/catkin_ws/src/beginner_tutorials/CMakeLists.txt @@ -3,7 +3,7 @@ cmake_minimum_required(VERSION 2.8.3) project(beginner_tutorials) ## Find catkin and any catkin packages -find_package(catkin REQUIRED COMPONENTS roscpp rospy std_msgs genmsg) +find_package(catkin REQUIRED COMPONENTS roscpp rospy std_msgs message_generation) ## Declare ROS messages and services add_message_files(FILES Num.msg) @@ -20,10 +20,10 @@ include_directories(include ${catkin_INCLUDE_DIRS}) add_executable(talker src/talker.cpp) target_link_libraries(talker ${catkin_LIBRARIES}) -add_dependencies(talker beginner_tutorials_generate_messages_cpp) +add_dependencies(talker ${catkin_EXPORTED_TARGETS}) add_executable(listener src/listener.cpp) target_link_libraries(listener ${catkin_LIBRARIES}) -add_dependencies(listener beginner_tutorials_generate_messages_cpp) +add_dependencies(listener ${catkin_EXPORTED_TARGETS}) # %EndTag(FULLTEXT)%