From 5fb60a39dd8f93ac57d64543eb0e0f700d800905 Mon Sep 17 00:00:00 2001
From: Robbie Bise <theil.bise@sonarsource.com>
Date: Thu, 22 Dec 2022 14:02:20 -0600
Subject: [PATCH 1/4] some bad code

---
 main/Main.class     | Bin 568 -> 591 bytes
 main/Main.java      |   8 +++++---
 main/OldStuff.class | Bin 399 -> 711 bytes
 main/OldStuff.java  |  26 ++++++++++++++++++++++++--
 4 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/main/Main.class b/main/Main.class
index c7d0b2dfa4083b374bc1abef3b59524989dcd7d7..7458e3a9244e4c1b1e85ffd887a34567b1d03f66 100644
GIT binary patch
delta 278
zcmW-a%`O806otP#Gwn<#Mx}|EqSW}Sw#n=*c!4$+7Q(JF8j{jTYV8@M4`I!s6%tDl
z8!zG!1ZQl%bAQgc_sRS8!jGTlS74v!UHHBm5F74kFY{S6qRZaJReCVU4o5fren=HJ
zM{R}`ibiQT$hv2v^P$}Jv13QJJwCDYb`?h#5sd;xaZO!KYSKb;ian?>5;0$cM~QVd
zROi-fMO|t7h+l~&l&w>l@3h_sHE5~N=L^yos>f57y6p+e_rG6?I3#<Lgh2GgfKaz1
bF&690(x6P6IX2}8uy10YEq!kM$9Mh!r+6om

delta 235
zcmW-Z%}N4c6o#Lpqn}P0?i@9LD*uQ;yaM;a;KGHt6elUL+}MT0T#1{Mgtmd3ZlFtv
z@E!T!dEdkNp7Z1FJ^%Rs`2`H=z5Cw-M_?3Q=FhMF@hX~Z-j++B66plhORmWp`SmIa
zA2(0y$Wf0kY-;UzVf|5!lnx;p8M0zSQ%z~g%>54Asu)c%S%XKO8*bH;uM4SZWjp@0
tAUsf-?I?#2A5;=Ab@u8wbw^Immt7D8vB?!Jiri_N!~O`IW}|a9yC*5U9-;sM

diff --git a/main/Main.java b/main/Main.java
index 3110f38..f8cc2ed 100644
--- a/main/Main.java
+++ b/main/Main.java
@@ -9,9 +9,11 @@ public static void main(String[] arguments) {
       a = "asdf";
       if (a != null) {out.println(a);}
       //TODO: something elsee
-
-      OldStuff oldStuff = new OldStuff();
-      oldStuff.oldMethod();
+      for (;true;) { 
+         out.println("bad"); 
+         OldStuff oldStuff = new OldStuff();
+         oldStuff.oldMethod();
+      }
    }
 }
 
diff --git a/main/OldStuff.class b/main/OldStuff.class
index c2e70b255a503ac74982ceee92529988fb68cd64..baeaa1027ab0923fd2e8da6a55d1f19dcb53b340 100644
GIT binary patch
literal 711
zcmZWm-%ry}6#i~kxNX-lEKX#CFclaZx<3G;4<<fsU{YejW4B&LvFjzZ)A$eRGsYi@
zCX%=}|0EyOubp7Phn{=S>G$KDbASB$@(sXaG#wZyNtiBXFe@;B9J~rTagYo<d;McI
z$OL8|MoE-C5-2sdo?EbZNmXdWL0Q6eQNf%*WfVk7XD<%@Y<zeqFf-7xP6fQ~KS4iB
zqhz>aV;<KeJQoYNe#y~)^D<K->gzFmYg1~ZJI~0=$X3B<$HEN(Q^#S$!A&el)Lq=d
zvcN)NbQvumPjYUYP_FrZEBQRP+3YY?iV*XO4wXQ)8zpLYJnE}-Kj_D-*!1hE>_~?K
z<xu;2#DueOZa)hKFM7dAfs|N3Z=_h^{!yx5PbC~*kJEvA8s&PG^F=+#n?{4XH255X
zk=x|0#5>=Eah2I7>w;&w^%<h&$&av43-}u2lv;rakD$f{Y5gzBevhhG`-H`-lqxK~
zgn>I3l()=GN^ZA4z&_}HZ+R=UYERz5>a{1^XJ26)umk=nYP;>p{j*atB&swAzglrN
za2FfQH?UQl2G*F>=>sAp7CGe-W1a0Tqm32ffhNq~q#F{B%zKx(_cJfeT`h6UT;0It
EALYe{K>z>%

delta 202
zcmX@k+Rw~&>ff$?3=9nR3^EhB^m#cMI2btD8Mt^DxEXjRb{dQFF*2~^=cFidF$gdS
zvNH(rFbFe<OuT3z%+4Uj$iSPMn3<>VpOX??Qks@FS%gu2auK6kp(q0r&`1U#$;iOU
zzy>76fjn6t%?PAfwYD=bZUizI86<!tNE$*)!j-CmwK6bpZem~;;@!r;k5JA9Hk$+F
NPM}69pjIXZX#j(c7xMrB

diff --git a/main/OldStuff.java b/main/OldStuff.java
index 0d8e10d..68436aa 100644
--- a/main/OldStuff.java
+++ b/main/OldStuff.java
@@ -2,9 +2,31 @@
 import static java.lang.System.out;
 
 
-// @Deprecated
+abstract class MyClass{
+
+}
+
+class AbstractLikeClass {
+
+}
+
 public class OldStuff {
    public void oldMethod(){
       out.println("old!");
    }
-}
\ No newline at end of file
+
+   private String color = "red";
+
+   private void doSomething(){
+   synchronized(color) {  // Noncompliant; lock is actually on object instance "red" referred to by the color variable
+      //...
+      color = "green"; // other threads now allowed into this block
+      // ...
+   }
+   synchronized(new Object()) { // Noncompliant this is a no-op.
+      // ...
+   }
+   }
+}
+
+

From 3211053c83ec7dbbd536dabc14c64daef5991489 Mon Sep 17 00:00:00 2001
From: Robbie Bise <theil.bise@sonarsource.com>
Date: Fri, 23 Dec 2022 10:48:59 -0600
Subject: [PATCH 2/4] add class

---
 .vscode/settings.json        |   6 ++++++
 main/AbstractLikeClass.class | Bin 0 -> 204 bytes
 main/MyClass.class           | Bin 0 -> 194 bytes
 3 files changed, 6 insertions(+)
 create mode 100644 .vscode/settings.json
 create mode 100644 main/AbstractLikeClass.class
 create mode 100644 main/MyClass.class

diff --git a/.vscode/settings.json b/.vscode/settings.json
new file mode 100644
index 0000000..fad1e95
--- /dev/null
+++ b/.vscode/settings.json
@@ -0,0 +1,6 @@
+{
+    "sonarlint.connectedMode.project": {
+        "connectionId": "http-localhost-9000-",
+        "projectKey": "robbiebise_test-java_AYUMz9uSsTqRf_H8TmDL"
+    }
+}
\ No newline at end of file
diff --git a/main/AbstractLikeClass.class b/main/AbstractLikeClass.class
new file mode 100644
index 0000000000000000000000000000000000000000..9cc887416e639205d7aebd1ed9f583b7e7ffe2c5
GIT binary patch
literal 204
zcmW+w!3u&<5S-P@GNn%4f{xW8e;|qwI!PXk?oWNjD>Kk%|J5nz&<FHU(dxqP?9L4A
ze1Go`fGu1b222Yb2VL|C<BNC*FBiqx3*(DSG@-Xvh0+^>IbWPC^a+!jP=&XPD_x32
z2kI*QTvQdI<KI(B7zL`3hx!)F@+jh*89TbyWg_>gIovQ$BVA|Ns(FSPEY8pradQgB
Y0dG^rmRY_)&sMg1HZs^i7&01g{wyUY<^TWy

literal 0
HcmV?d00001

diff --git a/main/MyClass.class b/main/MyClass.class
new file mode 100644
index 0000000000000000000000000000000000000000..0fedee1c30f51ce467cb23ebfe183f8b09ded629
GIT binary patch
literal 194
zcmX^0Z`VEs1_pZuUM>bE24;2!79Ivx1~x_pfvm)`ME#t^ymWp4q^#8B5=I6#o6Nk-
z5<5l)W)00Sb_Nbc2A<r+%shSHO6Q!!;$lVy7U%qwR7M7VpUk{eztY^K)S{5Yq#U3K
zS8#r5QF5wVCWyo9pOX??Qks^g2eN`ifq@-pGYBvOG0<)x%?V`50%@>_)^-NQjbLdm
RAPJHNDPv^d2GUFnJOGYtBk2GD

literal 0
HcmV?d00001


From 71807106b12e4976ea2b485c3d80e607a96ec8fb Mon Sep 17 00:00:00 2001
From: Robbie Bise <theil.bise@sonarsource.com>
Date: Fri, 30 Dec 2022 14:20:18 -0600
Subject: [PATCH 3/4] new todo

---
 .vscode/settings.json | 2 +-
 main/Main.java        | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index fad1e95..256e65e 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -1,6 +1,6 @@
 {
     "sonarlint.connectedMode.project": {
-        "connectionId": "http-localhost-9000-",
+        "connectionId": "http-localhost-9000",
         "projectKey": "robbiebise_test-java_AYUMz9uSsTqRf_H8TmDL"
     }
 }
\ No newline at end of file
diff --git a/main/Main.java b/main/Main.java
index f8cc2ed..9565233 100644
--- a/main/Main.java
+++ b/main/Main.java
@@ -9,6 +9,7 @@ public static void main(String[] arguments) {
       a = "asdf";
       if (a != null) {out.println(a);}
       //TODO: something elsee
+      //TODO: something elsee
       for (;true;) { 
          out.println("bad"); 
          OldStuff oldStuff = new OldStuff();

From a9639bf96d43b281dbcfd7c5f3332fa69b7ba94f Mon Sep 17 00:00:00 2001
From: Robbie Bise <theil.bise@sonarsource.com>
Date: Thu, 2 Feb 2023 10:56:35 -0600
Subject: [PATCH 4/4] some updates

---
 main/AbstractLikeClass.class | Bin 204 -> 0 bytes
 main/Main.java               |  18 +++++++++++++++++-
 main/MyClass.class           | Bin 194 -> 0 bytes
 3 files changed, 17 insertions(+), 1 deletion(-)
 delete mode 100644 main/AbstractLikeClass.class
 delete mode 100644 main/MyClass.class

diff --git a/main/AbstractLikeClass.class b/main/AbstractLikeClass.class
deleted file mode 100644
index 9cc887416e639205d7aebd1ed9f583b7e7ffe2c5..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 204
zcmW+w!3u&<5S-P@GNn%4f{xW8e;|qwI!PXk?oWNjD>Kk%|J5nz&<FHU(dxqP?9L4A
ze1Go`fGu1b222Yb2VL|C<BNC*FBiqx3*(DSG@-Xvh0+^>IbWPC^a+!jP=&XPD_x32
z2kI*QTvQdI<KI(B7zL`3hx!)F@+jh*89TbyWg_>gIovQ$BVA|Ns(FSPEY8pradQgB
Y0dG^rmRY_)&sMg1HZs^i7&01g{wyUY<^TWy

diff --git a/main/Main.java b/main/Main.java
index 9565233..802f223 100644
--- a/main/Main.java
+++ b/main/Main.java
@@ -9,12 +9,28 @@ public static void main(String[] arguments) {
       a = "asdf";
       if (a != null) {out.println(a);}
       //TODO: something elsee
-      //TODO: something elsee
+      //TODO: another task
+      for (;true;) { 
+         out.println("bad"); 
+         OldStuff oldStuff = new OldStuff();
+         oldStuff.oldMethod();
+      }
+
       for (;true;) { 
          out.println("bad"); 
          OldStuff oldStuff = new OldStuff();
          oldStuff.oldMethod();
       }
    }
+
+   void removeFrom(List<String> list) {
+      // expected: iterate over all the elements of the list
+      for (int i = 0; i < list.size(); i++) {
+        if (list.get(i).isEmpty()) {
+          // actual: remaining elements are shifted, so the one immediately following will be skipped
+          list.remove(i); // Noncompliant
+        }
+      }
+    }
 }
 
diff --git a/main/MyClass.class b/main/MyClass.class
deleted file mode 100644
index 0fedee1c30f51ce467cb23ebfe183f8b09ded629..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 194
zcmX^0Z`VEs1_pZuUM>bE24;2!79Ivx1~x_pfvm)`ME#t^ymWp4q^#8B5=I6#o6Nk-
z5<5l)W)00Sb_Nbc2A<r+%shSHO6Q!!;$lVy7U%qwR7M7VpUk{eztY^K)S{5Yq#U3K
zS8#r5QF5wVCWyo9pOX??Qks^g2eN`ifq@-pGYBvOG0<)x%?V`50%@>_)^-NQjbLdm
RAPJHNDPv^d2GUFnJOGYtBk2GD