-
Notifications
You must be signed in to change notification settings - Fork 40
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Have you ensured that all of these are up to date?
- This repo
- Any dependencies (according to the
package.json)
What command(s) is the bug in?
git submodule update --init
Operating System
None
Describe the bug
When installing this package via foundry, it is added as a submodule. But this repo has an invalid submodule at lib/modulekit - looks like it was added in c5c8691 but for some reason it was done without editing .gitmodules. This causes the submodule init to fail:
pablo:~/repos/modulekit (main)$ git submodule update --init
fatal: No url found for submodule path 'lib/modulekit' in .gitmodules
And since repos installing this will need to run git submodule update --init --recursive to install foundry dependencies, this breaks submodule installation for any repos installing this, with the same error message.
AFAICT the submodule isn't referenced anywhere so I believe it should be safe to delete it.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working