hard coded paths cause exceptions on non-default Moodle configurations

[durzo]

There are a few places that use hard coded paths such as $CFG->dataroot/temp/backup/ to look for the backup log and $CFG->dataroot/lang/ for language packs which may not always be correct and results in an exception if $CFG->backuptempdir or $CFG->langlocalroot have been changed.

in 3.9, backup location has also been moved to $CFG->localcachedir, which will also cause this to throw an exception. (MDL-68166)

Files:

elis/local/eliscore/lib/rollover/backup/stepslib.php

Line 49 in 2f1cb79

unlink($CFG->dataroot.'/temp/backup/'.$backupid.'.log');

elis/local/eliscore/lib/rollover/restore/stepslib.php

Line 44 in 2f1cb79

unlink($CFG->dataroot.'/temp/backup/'.$restoreid.'.log');

elis/local/eliscore/classes/install/migration/migrator.php

Line 159 in 2f1cb79

$langstringdir = $CFG->dataroot.'/lang/';