From 8d85622c31f9809e0a4c6df3e4e7e2472a29f74d Mon Sep 17 00:00:00 2001 From: juancgalvis <8420868+juancgalvis@users.noreply.github.com> Date: Fri, 2 Jan 2026 12:52:26 +0000 Subject: [PATCH 1/3] fix(deps): update dependencies --- build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.gradle b/build.gradle index 3cd9a356..e2dfb246 100644 --- a/build.gradle +++ b/build.gradle @@ -15,7 +15,7 @@ plugins { id 'org.sonarqube' version '7.2.2.6593' id 'org.springframework.boot' version '4.0.1' apply false id 'io.github.gradle-nexus.publish-plugin' version '2.0.0' - id 'co.com.bancolombia.cleanArchitecture' version '4.0.4' + id 'co.com.bancolombia.cleanArchitecture' version '4.0.5' } repositories { From ae1177dbf93c9add7a8d0f4aa719b6ba0ff23b3e Mon Sep 17 00:00:00 2001 From: jcgalvis Date: Thu, 15 Jan 2026 16:14:51 -0500 Subject: [PATCH 2/3] show health error details --- .../async-sender-client/src/main/resources/application.yaml | 5 +++-- .../config/health/ReactiveCommonsHealthIndicator.java | 2 +- .../async/rabbit/health/RabbitReactiveHealthIndicator.java | 6 +----- 3 files changed, 5 insertions(+), 8 deletions(-) diff --git a/samples/async/async-sender-client/src/main/resources/application.yaml b/samples/async/async-sender-client/src/main/resources/application.yaml index a4b247b1..1e8f4815 100644 --- a/samples/async/async-sender-client/src/main/resources/application.yaml +++ b/samples/async/async-sender-client/src/main/resources/application.yaml @@ -15,5 +15,6 @@ management: include: health,prometheus app: async: - createTopology: true - listenReplies: true + app: + createTopology: true + listenReplies: true diff --git a/starters/async-commons-starter/src/main/java/org/reactivecommons/async/starter/config/health/ReactiveCommonsHealthIndicator.java b/starters/async-commons-starter/src/main/java/org/reactivecommons/async/starter/config/health/ReactiveCommonsHealthIndicator.java index 8f35b758..b068563c 100644 --- a/starters/async-commons-starter/src/main/java/org/reactivecommons/async/starter/config/health/ReactiveCommonsHealthIndicator.java +++ b/starters/async-commons-starter/src/main/java/org/reactivecommons/async/starter/config/health/ReactiveCommonsHealthIndicator.java @@ -32,7 +32,7 @@ protected Mono doHealthCheck(Health.Builder builder) { private Health.Builder reduceHealth(Health.Builder builder, RCHealth health) { String domain = health.details().getOrDefault(DOMAIN, UNKNOWN).toString(); if (health.status().equals(RCHealth.Status.DOWN)) { - log.error("Broker of domain {} is down", domain); + log.error("Broker of domain {} is down {}", domain, health.details()); return builder.down().withDetail(domain, health.details()); } return builder.withDetail(domain, health.details()); diff --git a/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java b/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java index a80d5f1a..5e2a81c1 100644 --- a/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java +++ b/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java @@ -2,14 +2,11 @@ import com.rabbitmq.client.Connection; import com.rabbitmq.client.ConnectionFactory; -import lombok.SneakyThrows; import lombok.extern.log4j.Log4j2; import org.reactivecommons.async.starter.config.health.RCHealth; import org.reactivecommons.async.starter.config.health.RCHealthIndicator; import reactor.core.publisher.Mono; -import java.net.SocketException; - import static org.reactivecommons.async.starter.config.health.ReactiveCommonsHealthIndicator.DOMAIN; import static org.reactivecommons.async.starter.config.health.ReactiveCommonsHealthIndicator.VERSION; @@ -31,13 +28,12 @@ public Mono doHealthCheck(RCHealth.RCHealthBuilder builder) { .map(status -> builder.up().withDetail(VERSION, status).build()); } - @SneakyThrows private String getRawVersion(ConnectionFactory factory) { Connection connection = null; try { connection = factory.newConnection(); return connection.getServerProperties().get(VERSION).toString(); - } catch (SocketException e) { + } catch (Exception e) { log.warn("Identified error", e); throw new RabbitMQHealthException(e); } finally { From 6296fd510eab79d3eb12218dba6182883906db9f Mon Sep 17 00:00:00 2001 From: Juan C Galvis <8420868+juancgalvis@users.noreply.github.com> Date: Thu, 15 Jan 2026 16:30:06 -0500 Subject: [PATCH 3/3] fix(health): show health error details --- .../async/rabbit/health/RabbitReactiveHealthIndicator.java | 1 - .../async/rabbit/health/RabbitReactiveHealthIndicatorTest.java | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java b/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java index 5e2a81c1..02c3de0e 100644 --- a/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java +++ b/starters/async-rabbit-starter/src/main/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicator.java @@ -18,7 +18,6 @@ public class RabbitReactiveHealthIndicator extends RCHealthIndicator { public RabbitReactiveHealthIndicator(String domain, ConnectionFactory connectionFactory) { this.domain = domain; this.connectionFactory = connectionFactory.clone(); - this.connectionFactory.useBlockingIo(); } @Override diff --git a/starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicatorTest.java b/starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicatorTest.java index aa2ff9ba..9a698387 100644 --- a/starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicatorTest.java +++ b/starters/async-rabbit-starter/src/test/java/org/reactivecommons/async/rabbit/health/RabbitReactiveHealthIndicatorTest.java @@ -84,7 +84,7 @@ void shouldBeDown() throws IOException, TimeoutException { Mono result = indicator.doHealthCheck(RCHealth.builder()); // Assert StepVerifier.create(result) - .expectError(TimeoutException.class) + .expectError(RabbitMQHealthException.class) .verify(); }