From ebf8b79e38e08dbfc608389a7a0642ee00762811 Mon Sep 17 00:00:00 2001 From: rameel Date: Fri, 9 May 2025 03:23:37 +0500 Subject: [PATCH 1/3] Remove unnecessary SkipInternalsVisibleTo flag from build pipeline --- .github/workflows/publish.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 93eecfd..6640c4f 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -24,7 +24,7 @@ jobs: uses: actions/checkout@v4 - name: Build Solution - run: dotnet build -c Release -p:SkipInternalsVisibleTo=true + run: dotnet build -c Release - name: Create NuGet Packages run: dotnet pack -c Release -o ./nuget --no-build From 24790f6d40d6681479f7c3f6a267e3d3f17ef087 Mon Sep 17 00:00:00 2001 From: rameel Date: Fri, 9 May 2025 03:25:00 +0500 Subject: [PATCH 2/3] Clarify comment in ExpressionBuilder for null case --- src/Ramstack.ExpressionParser/ExpressionBuilder.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Ramstack.ExpressionParser/ExpressionBuilder.cs b/src/Ramstack.ExpressionParser/ExpressionBuilder.cs index 013853b..d099604 100644 --- a/src/Ramstack.ExpressionParser/ExpressionBuilder.cs +++ b/src/Ramstack.ExpressionParser/ExpressionBuilder.cs @@ -277,7 +277,7 @@ Expression ProcessMemberAccess(Expr.MemberAccess e) Error.NonInvocableMember(m); // - // It's not supposed to happen + // This shouldn't happen, but we'll crash if it does // if (expression is null) throw new InvalidOperationException( From 6fa6f1e31eb46634cbf74e7817a2a01da4f10798 Mon Sep 17 00:00:00 2001 From: rameel Date: Fri, 9 May 2025 03:26:26 +0500 Subject: [PATCH 3/3] Upgrade Ramstack.Parsing to 1.0.0-beta.7 --- Directory.Packages.props | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 6c9a94e..7bb21ca 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -9,6 +9,6 @@ - + - + \ No newline at end of file