Skip to content

[FEAT] log report content when report fails #370

@tigattack

Description

@tigattack

Overview

Improve report cog logging by capturing and logging report contents.

Describe the solution you'd like

Pasted from chat:

it's a hybrid command, usable as a typical command (^report) and slash command. When it's used as a slash command, it runs privately - Other users can't see it. Therefore there's nothing to clean up, which means the deletion of the report message isn't logged.
[...] it should really log the report when there's a failure. This failure was caught by the on_cmd_report_error() method. If anyone wishes to take a crack at it, I'd gladly review a PR.
It logs to console and DMs the bot owners (Muffin and I)
Both probably good places to include the original report.

The on_cmd_emergency_error() method should be patched in the same way.

Reports created with via text command don't suffer the same issue in our use case since we log deleted messages, but we shouldn't assume this is always the case. This new behaviour shouldn't explicitly exclude text command triggers.

Is this suggestion based on an existing problem? If so, please describe it

Reports can be lost forever if report delivery fails.

DoD

  • Report content is not lost when report delivery fails.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cog-reportIssues related to the report cog.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions