From a90ec7de8db482930adcd24b3958a8b6d28ccf59 Mon Sep 17 00:00:00 2001 From: SayMoon Date: Fri, 3 Jan 2025 10:44:17 +0100 Subject: [PATCH 1/3] Add prettier check to PR --- .github/workflows/quality.yaml | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) create mode 100644 .github/workflows/quality.yaml diff --git a/.github/workflows/quality.yaml b/.github/workflows/quality.yaml new file mode 100644 index 0000000..2454fe5 --- /dev/null +++ b/.github/workflows/quality.yaml @@ -0,0 +1,24 @@ +name: Quality + +on: + workflow_dispatch: +# pull_request: +# branches: +# - main + +## Cancel the previous run if a new one is triggered for the current branch +concurrency: + group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} + cancel-in-progress: true + +jobs: + prettier: + name: Prettier + runs-on: ubuntu-latest + + steps: + - name: Checkout + uses: actions/checkout@v3 + + - name: Echo something + run: echo "Hello, world!" From 1ce1103cf30c3901ee1388cfc620844454f508da Mon Sep 17 00:00:00 2001 From: SayMoon Date: Fri, 3 Jan 2025 10:58:12 +0100 Subject: [PATCH 2/3] Add prettier check to PR --- .github/workflows/quality.yaml | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/quality.yaml b/.github/workflows/quality.yaml index 2454fe5..5672ee4 100644 --- a/.github/workflows/quality.yaml +++ b/.github/workflows/quality.yaml @@ -19,6 +19,16 @@ jobs: steps: - name: Checkout uses: actions/checkout@v3 - - - name: Echo something - run: echo "Hello, world!" + with: + ref: ${{ github.head_ref }} + + - name: Setup Node.js + uses: actions/setup-node@v3 + + - name: Run Prettier + run: npx prettier --check './**/*.ts' + + - name: Success + run: | + echo "Prettier ran successfully" + echo "This is a test" From 90cba4174a46745cc0d35b6145c480963b1feb77 Mon Sep 17 00:00:00 2001 From: SayMoon Date: Fri, 3 Jan 2025 12:35:46 +0100 Subject: [PATCH 3/3] Add prettier check to PR --- .../{quality.yaml => quality-check.yaml} | 17 +++++------------ 1 file changed, 5 insertions(+), 12 deletions(-) rename .github/workflows/{quality.yaml => quality-check.yaml} (69%) diff --git a/.github/workflows/quality.yaml b/.github/workflows/quality-check.yaml similarity index 69% rename from .github/workflows/quality.yaml rename to .github/workflows/quality-check.yaml index 5672ee4..bb17fca 100644 --- a/.github/workflows/quality.yaml +++ b/.github/workflows/quality-check.yaml @@ -1,10 +1,9 @@ -name: Quality +name: Quality Check on: - workflow_dispatch: -# pull_request: -# branches: -# - main + pull_request: + branches: + - main ## Cancel the previous run if a new one is triggered for the current branch concurrency: @@ -13,9 +12,8 @@ concurrency: jobs: prettier: - name: Prettier + name: Check with Prettier runs-on: ubuntu-latest - steps: - name: Checkout uses: actions/checkout@v3 @@ -27,8 +25,3 @@ jobs: - name: Run Prettier run: npx prettier --check './**/*.ts' - - - name: Success - run: | - echo "Prettier ran successfully" - echo "This is a test"