[bug] NoMethodError: undefined method `prepare_for_render`

[jhollinger]

Is there an existing issue for this?

• I have searched the existing issues

Is this a regression?

• Yes, this used to work before

Current Behavior

No response

Expected Behavior

No response

Steps To Reproduce

The removal of prepare_for_render in main is causing errors in our own app's test suite. Apparently we're using it in several of our Blueprints and for some kind of tracing. Unsure if we should patch in our app or re-introduce the method...

Environment

Procore production.

Anything else?

No response

[lessthanjacob]

Since .prepare_for_render was a private method, we didn't do any intentional deprecation, and opted to refactor in place.

Based on what I'm seeing, it looks like there's two primary calls:

1. Converting an object into a Hash representation using the relevant blueprint.
2. Wrapping .prepare_for_render (and other private methods) in a span for telemetry purposes (like you called out).

For the first, we have a direct equivalent in .render_as_hash, which is public (though I'd expect that what we actually want is .hashify, since that won't include root or meta attributes).

For the second, we should work with the team to understand what information they're trying to get out of the spans/traces. I know we intend to have improved telemetry hooks in the next version, but we might be able to provide something in the short term.

In any case, we should refactor any call sites that were previously dependent on private methods.

[jhollinger]

Yeah, hashify gives the expected result in most of these cases. Might be something to keep in mind for V2: an official way to serialize but skip root and meta...