Add option to cache the config

[tcbyrd]

Currently we make a call to repo.getContents() for every request to check the configuration. This can have a negative effect on API rate limits since an app has to use up a request to get the contents of a file that doesn't change very often. We should provide a way in this plugin to cache the config, and listen for webhook events that change the file to ensure it's always up to date what the state of the file in the repo. To help limit issues where the app may have missed that webhook event, we can limit the age of the cache to 30/60 minutes so that it regularly goes back to the source to get a fresh copy.

[gr2m]

I guess we can’t fully rely on webhooks because some apps don’t have file read access and rely on the fact that the repository is open source? Or the app does not have the right webhooks enabled?

Either way, 💯 agree

[gr2m]

Oh there is another trick we could use in theory: if the repo is public, we can load the file from https://raw.githubusercontent.com/ instead of using the rest API. E.g. https://raw.githubusercontent.com/probot/probot-config/master/.github/release.yml

GitHub

Build software better, together

GitHub is where people build software. More than 31 million people use GitHub to discover, fork, and contribute to over 100 million projects.

[tcbyrd]

Or the app does not have the right webhooks enabled?

Yeh I realized you can’t event subscribe to the `push` event if your app doesn’t have repo contents permission, so if you only have single file access there is no way to be notified of that file changing. I think we should instead probably make use of conditional requests here.

…

On Tue, Feb 12, 2019 at 3:34 PM Gregor Martynus ***@***.***> wrote: I guess we can’t fully rely on webhooks because some apps don’t have file read access and rely on the fact that the repository is open source? Or the app does not have the right webhooks enabled? Either way, 💯 agree — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#32 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMmHNLvlv9XywWnAT2BCLJmAECKh3YRUks5vMyVtgaJpZM4alXEs> .