From e68ae966321b90c7a6b95658a71ad534e4143cd0 Mon Sep 17 00:00:00 2001
From: Bouwe Westerdijk <bouwe.s.westerdijk@gmail.com>
Date: Mon, 17 Feb 2025 20:22:40 +0100
Subject: [PATCH 1/5] Remove f-strings with .strip(), not working

---
 plugwise/legacy/smile.py |  78 +++++++++++-----------
 plugwise/smile.py        | 140 +++++++++++++++++++--------------------
 2 files changed, 109 insertions(+), 109 deletions(-)

diff --git a/plugwise/legacy/smile.py b/plugwise/legacy/smile.py
index 02bd74abf..ed3c74629 100644
--- a/plugwise/legacy/smile.py
+++ b/plugwise/legacy/smile.py
@@ -172,14 +172,14 @@ async def set_preset(self, _: str, preset: str) -> None:
 
         locator = f'rule/directives/when/then[@icon="{preset}"].../.../...'
         rule = self._domain_objects.find(locator)
-        data = f'''
-            <rules>
-                <rule id="{rule.attrib["id"]}">
-                    <active>true</active>
-                </rule>
-            </rules>
-        '''
-        await self.call_request(RULES, method="put", data=data.strip())
+        data = (
+            "<rules>"
+            "<rule id='{rule.attrib['id']}'>"
+            "<active>true</active>"
+            "</rule>"
+            "</rules>"
+        )
+        await self.call_request(RULES, method="put", data=data)
 
     async def set_regulation_mode(self, mode: str) -> None:
         """Set-function placeholder for legacy devices."""
@@ -224,17 +224,17 @@ async def set_schedule_state(
         for rule in self._domain_objects.findall(locator):
             template_id = rule.attrib["id"]
 
-        data = f'''
-            <rules>
-                <rule id="{schedule_rule_id}">
-                    <name><![CDATA[{name}]]></name>
-                    <template id="{template_id}" />
-                    <active>{new_state}</active>
-                </rule>
-            </rules>
-        '''
+        data = (
+            "<rules>"
+            f"<rule id='{schedule_rule_id}'>"
+            f"<name><![CDATA[{name}]]></name>"
+            f"<template id='{template_id}' />"
+            f"<active>{new_state}</active>"
+            "</rule>"
+            "</rules>"
+        )
         uri = f"{RULES};id={schedule_rule_id}"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def set_switch_state(
         self, appl_id: str, members: list[str] | None, model: str, state: str
@@ -258,21 +258,21 @@ async def set_switch_state(
             appliance = self._appliances.find(f'appliance[@id="{appl_id}"]')
             appl_name = appliance.find("name").text
             appl_type = appliance.find("type").text
-            data = f'''
-                <appliances>
-                    <appliance id="{appl_id}">
-                        <name><![CDATA[{appl_name}]]></name>
-                        <description><![CDATA[]]></description>
-                        <type><![CDATA[{appl_type}]]></type>
-                        <{switch.actuator}>
-                            <{switch.func_type}>
-                                <lock>{state}</lock>
-                            </{switch.func_type}>
-                        </{switch.actuator}>
-                    </appliance>
-                </appliances>
-            '''
-            await self.call_request(APPLIANCES, method="post", data=data.strip())
+            data = (
+                "<appliances>"
+                f"<appliance id='{appl_id}'>"
+                f"<name><![CDATA[{appl_name}]]></name>"
+                f"<description><![CDATA[]]></description>"
+                f"<type><![CDATA[{appl_type}]]></type>"
+                f"<{switch.actuator}>"
+                f"<{switch.func_type}>"
+                f"<lock>{state}</lock>"
+                f"</{switch.func_type}>"
+                f"</{switch.actuator}>"
+                "</appliance>"
+                "</appliances>"
+            )
+            await self.call_request(APPLIANCES, method="post", data=data)
             return
 
         # Handle group of switches
@@ -317,13 +317,13 @@ async def set_temperature(self, _: str, items: dict[str, float]) -> None:
             )  # pragma: no cover"
 
         temperature = str(setpoint)
-        data = f"""
-            <thermostat_functionality>
-                <setpoint>{temperature}</setpoint>
-            </thermostat_functionality>
-        """
+        data = (
+            "<thermostat_functionality>"
+            f"<setpoint>{temperature}</setpoint>"
+            "</thermostat_functionality>"
+        )
         uri = self._thermostat_uri()
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def call_request(self, uri: str, **kwargs: Any) -> None:
         """ConnectionFailedError wrapper for calling request()."""
diff --git a/plugwise/smile.py b/plugwise/smile.py
index d90ce89fe..4f65be990 100644
--- a/plugwise/smile.py
+++ b/plugwise/smile.py
@@ -174,13 +174,13 @@ async def set_number(
         if thermostat_id is None:
             raise PlugwiseError(f"Plugwise: cannot change setpoint, {key} not found.")
 
-        data = f"""
-            <thermostat_functionality>
-                <setpoint>{temp}</setpoint>
-            </thermostat_functionality>
-        """
+        data = (
+            "<thermostat_functionality>"
+            f"<setpoint>{temp}</setpoint>"
+            "</thermostat_functionality>"
+        )
         uri = f"{APPLIANCES};id={self._heater_id}/thermostat;id={thermostat_id}"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def set_offset(self, dev_id: str, offset: float) -> None:
         """Set the Temperature offset for thermostats that support this feature."""
@@ -190,13 +190,13 @@ async def set_offset(self, dev_id: str, offset: float) -> None:
             )
 
         value = str(offset)
-        data = f"""
-            <offset_functionality>
-                <offset>{value}</offset>
-            </offset_functionality>
-        """
+        data = (
+            "<offset_functionality>"
+            f"<offset>{value}</offset>"
+            "</offset_functionality>"
+        )
         uri = f"{APPLIANCES};id={dev_id}/offset;type=temperature_offset"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def set_preset(self, loc_id: str, preset: str) -> None:
         """Set the given Preset on the relevant Thermostat - from LOCATIONS."""
@@ -208,17 +208,17 @@ async def set_preset(self, loc_id: str, preset: str) -> None:
         current_location = self._domain_objects.find(f'location[@id="{loc_id}"]')
         location_name = current_location.find("name").text
         location_type = current_location.find("type").text
-        data = f'''
-            <locations>
-                <location id="{loc_id}">
-                    <name>{location_name}</name>
-                    <type>{location_type}</type>
-                    <preset>{preset}</preset>
-                </location>
-            </locations>
-        '''
+        data = (
+            "<locations>"
+            f"<location id='{loc_id}''>"
+            f"<name>{location_name}</name>"
+            f"<type>{location_type}</type>"
+            f"<preset>{preset}</preset>"
+            "</location>"
+            "</locations>"
+        )
         uri = f"{LOCATIONS};id={loc_id}"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def set_select(
         self, key: str, loc_id: str, option: str, state: str | None
@@ -240,13 +240,13 @@ async def set_dhw_mode(self, mode: str) -> None:
         if mode not in self._dhw_allowed_modes:
             raise PlugwiseError("Plugwise: invalid dhw mode.")
 
-        data = f"""
-            <domestic_hot_water_mode_control_functionality>
-                <mode>{mode}</mode>
-            </domestic_hot_water_mode_control_functionality>
-        """
+        data = (
+            "<domestic_hot_water_mode_control_functionality>"
+            f"<mode>{mode}</mode>"
+            "</domestic_hot_water_mode_control_functionality>"
+        )
         uri = f"{APPLIANCES};type=heater_central/domestic_hot_water_mode_control"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def set_gateway_mode(self, mode: str) -> None:
         """Set the gateway mode."""
@@ -271,14 +271,14 @@ async def set_gateway_mode(self, mode: str) -> None:
             vacation_time = time_2 + "T23:00:00.000Z"
             valid = f"<valid_from>{vacation_time}</valid_from><valid_to>{end_time}</valid_to>"
 
-        data = f"""
-            <gateway_mode_control_functionality>
-                <mode>{mode}</mode>
-                {valid}
-            </gateway_mode_control_functionality>
-        """
+        data = (
+            "<gateway_mode_control_functionality>"
+            f"<mode>{mode}</mode>"
+            f"{valid}"
+            "</gateway_mode_control_functionality>"
+        )
         uri = f"{APPLIANCES};id={self._smile_props['gateway_id']}/gateway_mode_control"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def set_regulation_mode(self, mode: str) -> None:
         """Set the heating regulation mode."""
@@ -289,14 +289,14 @@ async def set_regulation_mode(self, mode: str) -> None:
         if "bleeding" in mode:
             duration = "<duration>300</duration>"
 
-        data = f"""
-            <regulation_mode_control_functionality>
-                {duration}
-                <mode>{mode}</mode>
-            </regulation_mode_control_functionality>
-        """
+        data = (
+            "<regulation_mode_control_functionality>"
+            f"{duration}"
+            f"<mode>{mode}</mode>"
+            "</regulation_mode_control_functionality>"
+        )
         uri = f"{APPLIANCES};type=gateway/regulation_mode_control"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def set_schedule_state(
         self,
@@ -344,17 +344,17 @@ async def set_schedule_state(
             template = f'<template id="{template_id}" />'
 
         contexts = self.determine_contexts(loc_id, name, new_state, schedule_rule_id)
-        data = f'''
-            <rules>
-                <rule id="{schedule_rule_id}">
-                    <name><![CDATA[{name}]]></name>
-                    {template}
-                    {contexts}
-                </rule>
-            </rules>
-        '''
+        data = (
+            "<rules>"
+            f"<rule id='{schedule_rule_id}'>"
+            f"<name><![CDATA[{name}]]></name>"
+            f"{template}"
+            f"{contexts}"
+            "</rule>"
+            "</rules>"
+        )
         uri = f"{RULES};id={schedule_rule_id}"
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
         self._schedule_old_states[loc_id][name] = new_state
 
     def determine_contexts(
@@ -412,11 +412,11 @@ async def set_switch_state(
                 switch_id = item.attrib["id"]
                 break
 
-        data = f"""
-            <{switch.func_type}>
-                <{switch.func}>{state}</{switch.func}>
-            </{switch.func_type}>
-        """
+        data = (
+            f"<{switch.func_type}>"
+            f"<{switch.func}>{state}</{switch.func}>"
+            f"</{switch.func_type}>"
+        )
         uri = f"{APPLIANCES};id={appl_id}/{switch.device};id={switch_id}"
         if model == "relay":
             locator = (
@@ -426,7 +426,7 @@ async def set_switch_state(
             if self._domain_objects.find(locator).text == "true":
                 raise PlugwiseError("Plugwise: the locked Relay was not switched.")
 
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def _set_groupswitch_member_state(
         self, members: list[str], state: str, switch: Munch
@@ -439,12 +439,12 @@ async def _set_groupswitch_member_state(
             locator = f'appliance[@id="{member}"]/{switch.actuator}/{switch.func_type}'
             switch_id = self._domain_objects.find(locator).attrib["id"]
             uri = f"{APPLIANCES};id={member}/{switch.device};id={switch_id}"
-            data = f"""
-                <{switch.func_type}>
-                    <{switch.func}>{state}</{switch.func}>
-                </{switch.func_type}>
-            """
-            await self.call_request(uri, method="put", data=data.strip())
+            data = (
+                f"<{switch.func_type}>"
+                f"<{switch.func}>{state}</{switch.func}>"
+                f"</{switch.func_type}>"
+            )
+            await self.call_request(uri, method="put", data=data)
 
     async def set_temperature(self, loc_id: str, items: dict[str, float]) -> None:
         """Set the given Temperature on the relevant Thermostat."""
@@ -479,13 +479,13 @@ async def set_temperature(self, loc_id: str, items: dict[str, float]) -> None:
             )  # pragma: no cover"
 
         temperature = str(setpoint)
-        data = f"""
-            <thermostat_functionality>
-                <setpoint>{temperature}</setpoint>
-            </thermostat_functionality>
-        """
+        data = (
+            "<thermostat_functionality>"
+            f"<setpoint>{temperature}</setpoint>"
+            "</thermostat_functionality>"
+        )
         uri = self._thermostat_uri(loc_id)
-        await self.call_request(uri, method="put", data=data.strip())
+        await self.call_request(uri, method="put", data=data)
 
     async def call_request(self, uri: str, **kwargs: Any) -> None:
         """ConnectionFailedError wrapper for calling request()."""

From 33067741c9944ed838613c4e0ef3ea9426ed05d8 Mon Sep 17 00:00:00 2001
From: autoruff <plugwise@users.noreply.github.com>
Date: Mon, 17 Feb 2025 19:24:12 +0000
Subject: [PATCH 2/5] fixup: redo-xml Python code fixed using ruff

---
 plugwise/legacy/smile.py | 6 +-----
 plugwise/smile.py        | 6 +-----
 2 files changed, 2 insertions(+), 10 deletions(-)

diff --git a/plugwise/legacy/smile.py b/plugwise/legacy/smile.py
index ed3c74629..c370835cc 100644
--- a/plugwise/legacy/smile.py
+++ b/plugwise/legacy/smile.py
@@ -173,11 +173,7 @@ async def set_preset(self, _: str, preset: str) -> None:
         locator = f'rule/directives/when/then[@icon="{preset}"].../.../...'
         rule = self._domain_objects.find(locator)
         data = (
-            "<rules>"
-            "<rule id='{rule.attrib['id']}'>"
-            "<active>true</active>"
-            "</rule>"
-            "</rules>"
+            "<rules><rule id='{rule.attrib['id']}'><active>true</active></rule></rules>"
         )
         await self.call_request(RULES, method="put", data=data)
 
diff --git a/plugwise/smile.py b/plugwise/smile.py
index 4f65be990..aec1a6fa8 100644
--- a/plugwise/smile.py
+++ b/plugwise/smile.py
@@ -190,11 +190,7 @@ async def set_offset(self, dev_id: str, offset: float) -> None:
             )
 
         value = str(offset)
-        data = (
-            "<offset_functionality>"
-            f"<offset>{value}</offset>"
-            "</offset_functionality>"
-        )
+        data = f"<offset_functionality><offset>{value}</offset></offset_functionality>"
         uri = f"{APPLIANCES};id={dev_id}/offset;type=temperature_offset"
         await self.call_request(uri, method="put", data=data)
 

From 6c1fc6aec87ec12fa08580bf02376f161a950e01 Mon Sep 17 00:00:00 2001
From: Bouwe Westerdijk <bouwe.s.westerdijk@gmail.com>
Date: Mon, 17 Feb 2025 20:28:29 +0100
Subject: [PATCH 3/5] Add missing starting-f

---
 plugwise/legacy/smile.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugwise/legacy/smile.py b/plugwise/legacy/smile.py
index c370835cc..f45d5fead 100644
--- a/plugwise/legacy/smile.py
+++ b/plugwise/legacy/smile.py
@@ -173,7 +173,7 @@ async def set_preset(self, _: str, preset: str) -> None:
         locator = f'rule/directives/when/then[@icon="{preset}"].../.../...'
         rule = self._domain_objects.find(locator)
         data = (
-            "<rules><rule id='{rule.attrib['id']}'><active>true</active></rule></rules>"
+            f"<rules><rule id='{rule.attrib['id']}'><active>true</active></rule></rules>"
         )
         await self.call_request(RULES, method="put", data=data)
 

From 6f42cae6b5439959e939950f6c40b65ed11d9b8f Mon Sep 17 00:00:00 2001
From: Bouwe Westerdijk <bouwe.s.westerdijk@gmail.com>
Date: Mon, 17 Feb 2025 20:31:09 +0100
Subject: [PATCH 4/5] Fix SonarCloud issue

---
 plugwise/legacy/smile.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/plugwise/legacy/smile.py b/plugwise/legacy/smile.py
index f45d5fead..7d69c26ff 100644
--- a/plugwise/legacy/smile.py
+++ b/plugwise/legacy/smile.py
@@ -171,9 +171,9 @@ async def set_preset(self, _: str, preset: str) -> None:
             raise PlugwiseError("Plugwise: invalid preset.")
 
         locator = f'rule/directives/when/then[@icon="{preset}"].../.../...'
-        rule = self._domain_objects.find(locator)
+        rule_id = self._domain_objects.find(locator).attrib["id"]
         data = (
-            f"<rules><rule id='{rule.attrib['id']}'><active>true</active></rule></rules>"
+            f"<rules><rule id='{rule_id}'><active>true</active></rule></rules>"
         )
         await self.call_request(RULES, method="put", data=data)
 

From 22ec44f9e8e8bdb385e1618bb1686329c195de7e Mon Sep 17 00:00:00 2001
From: Bouwe Westerdijk <bouwe.s.westerdijk@gmail.com>
Date: Tue, 18 Feb 2025 08:07:04 +0100
Subject: [PATCH 5/5] Ruff fix

---
 plugwise/legacy/smile.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/plugwise/legacy/smile.py b/plugwise/legacy/smile.py
index 7d69c26ff..7cd22032c 100644
--- a/plugwise/legacy/smile.py
+++ b/plugwise/legacy/smile.py
@@ -172,9 +172,7 @@ async def set_preset(self, _: str, preset: str) -> None:
 
         locator = f'rule/directives/when/then[@icon="{preset}"].../.../...'
         rule_id = self._domain_objects.find(locator).attrib["id"]
-        data = (
-            f"<rules><rule id='{rule_id}'><active>true</active></rule></rules>"
-        )
+        data = f"<rules><rule id='{rule_id}'><active>true</active></rule></rules>"
         await self.call_request(RULES, method="put", data=data)
 
     async def set_regulation_mode(self, mode: str) -> None: