Files seems to mix CRLF and LF line endings

[Girgias]

I was doing a partial sync of reference/mysql and saw that the reference/mysql/functions/mysql-set-charset.xml file uses CRLF new lines.

It would be good to fix them so that all of them uses LF new lines.

[DavidePastore]

Hi @Girgias, thanks for raising this issue. Could you please tell me if this issue could somehow negatively affect the build or the translation process?

[Girgias]

It wouldn't affect the build not the translation process, except that it might be difficult to apply a doc-en commit onto the translation.

This is more a QA issue than anything else :)

[alfsb]

The presence of \r on text files is now generating 40+ warnings on doc-it. Things like:

Wrong XML file:
  Issue: XML file contains \r. Several tools may misbehave.
  Path:  /home/andre/phpdoc-test/it/appendices/reserved.constants.standard.xml
  Hint:  You can try autofix this with 'doc-base/scripts/broken.php --dos2unix langdir'.

These warnings are only visible on Linux machines. There are also wrongly encoded files, as reported on #73 . This is visible on all machines. As reported, having \r on text files may cause tools to misbehave. This does not break the manual build for now, but may cause manual breaks in future.

@Girgias

I opened a PR on doc-base today, related to translations where Windows tools do not preserve Unix end of line marks.

That said, there are some 1600+ files on doc-it using the \n end of line, and only 45 files with \r. I think it's safe to dos2unix these files, and if someone complains about Windows tooling, then the proposed change on doc-base/docs/local-setup.md may be an alternative.

[alfsb]

The instructions for Windows translators are now merged: https://github.com/php/doc-base/blob/master/docs/local-setup.md#translating-on-windows

They are not fully tested yet, but they worked well in my machine. Issuing the commands for local transforming the files for native Windows end-of-line marks will flag the same files that configure.php complains as Wrong XML file, because these files contains \r at repository level.