Skip to content

AccessibleValueHandler could automatically speak voicing context responses #936

@samreid

Description

@samreid

This patch worked well in Membrane Transport, but we would need more time to see if it interferes with existing voicing in other sims:

Details
Subject: [PATCH] 
---
Index: js/accessibility/AccessibleValueHandler.ts
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/accessibility/AccessibleValueHandler.ts b/js/accessibility/AccessibleValueHandler.ts
--- a/js/accessibility/AccessibleValueHandler.ts	(revision 85e6e37ec5666ae6a90a32f7f52536f91368702d)
+++ b/js/accessibility/AccessibleValueHandler.ts	(date 1745014557774)
@@ -47,9 +47,6 @@
 import type UtteranceQueue from '../../../utterance-queue/js/UtteranceQueue.js';
 import sun from '../sun.js';
 import AccessibleValueHandlerHotkeyDataCollection from './AccessibleValueHandlerHotkeyDataCollection.js';
-import { numberOfDecimalPlaces } from '../../../dot/js/util/numberOfDecimalPlaces.js';
-import { roundSymmetric } from '../../../dot/js/util/roundSymmetric.js';
-import { equalsEpsilon } from '../../../dot/js/util/equalsEpsilon.js';
 
 // constants
 const DEFAULT_TAG_NAME = 'input';
@@ -737,6 +734,10 @@
                 this._timesChangedBeforeAlerting * this._contextResponsePerValueChangeDelay );
 
               utteranceQueue.addToBack( this._contextResponseUtterance );
+
+              this.voicingSpeakContextResponse( {
+                contextResponse: endInteractionAlert
+              } );
             } );
           }
         }

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions