Skip to content

Some font awesome shapes fail to render #88

@samreid

Description

@samreid

From phetsims/sherpa#81.

These icons throw errors during Shape construction:

Amazon
Aviato
Bitcoin
CanadianMapleLeaf
CcAmex
CcJcb
CcVisa
Confluence
DAndDBeyond
Discord
Discourse
DumpsterFire
Ember
Evernote
FilePdf
FireAlt
FirefoxBrowser
FreeCodeCamp
Frog
GithubSquare
Grav
Gripfire
Grunt
Hooli
Hornbill
ItchIo
ItunesNote
Java
JediOrder
Jira
Keycdn
KissWinkHeart
Language
Lastfm
Lyft
Mdb
Napster
Odnoklassniki
Pagelines
Paypal
Phabricator
PinterestSquare
Playstation
Pushed
PuzzlePiece
RProject
Rebel
Ribbon
Rockrms
Salesforce
Sass
Shopify
Studiovinari
StumbleuponCircle
Usps
Viber
Vnv
WatchmanMonitoring
Wix
WizardsOfTheCoast
Wordpress
Yarn
YoutubeSquare
Zhihu

For instance, Amazon throws this error (when asserts are enabled):

Vector2.js:256 Uncaught Error: Cannot normalize a zero-magnitude vector
    at Vector2.normalized (Vector2.js:256)
    at Cubic.getEndTangent (Cubic.js:361)
    at Cubic.get endTangent [as endTangent] (Cubic.js:365)
    at Subpath.addSegmentDirectly (Subpath.js:165)
    at Subpath.addSegment (Subpath.js:187)
    at Shape.addSegmentAndBounds (Shape.js:1744)
    at Shape.js:596
    at u (lodash-4.17.4.min.js:5)
    at Function.ru (lodash-4.17.4.min.js:67)
    at Shape.cubicCurveToPoint (Shape.js:595)

I saw another failure mode with assertions disabled, but cannot figure out which icon(s) it was for, where NaN are leaking into the path commands.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions