Skip to content

pattern for stripping binder documentation  #23

@pixelzoom

Description

@pixelzoom

I see 12 occurrence of

assert && phet.chipper.queryParameters.binder ...

For example, in Slider.js:

// support for binder documentation, stripped out in builds and only runs when ?binder is specified
assert && phet.chipper.queryParameters.binder && InstanceRegistry.registerDataURL( 'sun', 'Slider', this );

Using assert in this way (to strip out things other than assert) seems a bit questionable. Labeling for discussion at developer meeting.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions