diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 0815d82..8d3de14 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -34,5 +34,8 @@ jobs: - name: Validate run: ./mvnw -B clean validate + - name: Check spotbugs + run: ./mvnw -B -DskipTests=true -P check-spotbugs verify + - name: Tests run: ./mvnw -B -DwebDriverType=chrome verify diff --git a/pom.xml b/pom.xml index f1d75ad..94268bb 100644 --- a/pom.xml +++ b/pom.xml @@ -22,6 +22,10 @@ 1.1.1 0.8.11 + + 4.7.3.4 + 3.0.1 + 1.13.0 @@ -36,6 +40,11 @@ springdoc-openapi-starter-common ${springdoc.version} + + com.google.code.findbugs + findbugs-annotations + ${findbugs-annotations.version} + @@ -91,6 +100,10 @@ hsqldb runtime + + com.google.code.findbugs + findbugs-annotations + @@ -140,6 +153,24 @@ + + com.github.spotbugs + spotbugs-maven-plugin + ${spotbugs-maven-plugin.version} + + + + com.h3xstream.findsecbugs + findsecbugs-plugin + ${findsecbugs-plugin.version} + + + true + true + Max + true + + org.jacoco jacoco-maven-plugin @@ -206,6 +237,27 @@ + + + check-spotbugs + + + + com.github.spotbugs + spotbugs-maven-plugin + + + + check + + + + + + + + + conta Conta do Desenvolvimento de Sistemas Corporativos https://github.com/persapiens/conta diff --git a/src/main/java/br/edu/ifrn/conta/domain/Categoria.java b/src/main/java/br/edu/ifrn/conta/domain/Categoria.java index ae889d3..bfe566b 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Categoria.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Categoria.java @@ -3,6 +3,7 @@ import java.io.Serializable; import java.util.Set; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Column; import jakarta.persistence.Entity; import jakarta.persistence.GeneratedValue; @@ -24,6 +25,7 @@ /** * Categoria entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString(exclude = "contas") diff --git a/src/main/java/br/edu/ifrn/conta/domain/Conta.java b/src/main/java/br/edu/ifrn/conta/domain/Conta.java index 090ea31..1880d06 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Conta.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Conta.java @@ -15,6 +15,7 @@ import jakarta.persistence.SequenceGenerator; import java.util.Comparator; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.AllArgsConstructor; import lombok.EqualsAndHashCode; import lombok.Getter; @@ -27,6 +28,7 @@ /** * Conta abstract entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Getter @Setter diff --git a/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java b/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java index d0a29ac..8bdc94d 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java +++ b/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java @@ -2,6 +2,7 @@ import java.util.Set; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Entity; import jakarta.persistence.OneToMany; @@ -17,6 +18,7 @@ /** * Conta Patrimonio entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Getter @Setter diff --git a/src/main/java/br/edu/ifrn/conta/domain/Dono.java b/src/main/java/br/edu/ifrn/conta/domain/Dono.java index 5a608e9..318f581 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Dono.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Dono.java @@ -3,6 +3,7 @@ import java.io.Serializable; import java.util.Set; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Column; import jakarta.persistence.Entity; import jakarta.persistence.GeneratedValue; @@ -24,6 +25,7 @@ /** * Dono entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString(of = "descricao") diff --git a/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java b/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java index e69128a..37d426f 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java @@ -5,6 +5,7 @@ import java.time.LocalDateTime; import java.util.Comparator; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Column; import jakarta.persistence.Entity; import jakarta.persistence.ForeignKey; @@ -27,6 +28,7 @@ /** * Lancamento entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString diff --git a/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java b/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java index 4c75caa..1a2cd88 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java +++ b/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java @@ -14,6 +14,7 @@ import jakarta.persistence.SequenceGenerator; import java.util.Comparator; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.AccessLevel; import lombok.AllArgsConstructor; import lombok.experimental.SuperBuilder; @@ -26,6 +27,7 @@ /** * Valor Inicial do Dono na Conta Patrimonio entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString diff --git a/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java b/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java index 0344b2d..448d32c 100644 --- a/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java +++ b/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java @@ -1,6 +1,8 @@ package br.edu.ifrn.conta.dto; import java.io.Serializable; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.Data; import lombok.NoArgsConstructor; import lombok.ToString; @@ -9,6 +11,7 @@ /** * DTO interface. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data @ToString diff --git a/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java b/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java index a5a62bb..02afe89 100644 --- a/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java +++ b/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java @@ -3,6 +3,8 @@ import java.io.Serializable; import java.math.BigDecimal; import java.time.LocalDateTime; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import lombok.NoArgsConstructor; @@ -11,6 +13,7 @@ /** * DTO interface. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data @ToString diff --git a/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java b/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java index 635d394..8ce521d 100644 --- a/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java +++ b/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java @@ -2,6 +2,8 @@ import java.io.Serializable; import java.math.BigDecimal; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import lombok.NoArgsConstructor; @@ -10,6 +12,7 @@ /** * DTO interface. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data @ToString diff --git a/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java index 78fa97e..cbba756 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class CategoriaRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java index ee84f3c..6219ff1 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.ContaCreditoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ContaCreditoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java index be12ae7..bbfcbc2 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.ContaDebitoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ContaDebitoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java index 5f8938a..f527048 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.ContaPatrimonioDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ContaPatrimonioRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java index 37d31cc..d0ca317 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.DonoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class DonoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java index 6c3f65d..765144d 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java @@ -2,10 +2,12 @@ import br.edu.ifrn.conta.dto.LancamentoDTO; import java.math.BigDecimal; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class LancamentoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java b/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java index 990ab9f..20c3c03 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java @@ -3,12 +3,14 @@ import java.net.URI; import lombok.experimental.SuperBuilder; import lombok.Data; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.springframework.core.ParameterizedTypeReference; import org.springframework.http.HttpEntity; import org.springframework.http.HttpMethod; import org.springframework.web.client.RestTemplate; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class RestClientHelper { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java index f909890..ae6acc6 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java @@ -2,10 +2,12 @@ import br.edu.ifrn.conta.dto.LancamentoDTO; import java.math.BigDecimal; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class SaldoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java index 0561186..4789baf 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java @@ -1,11 +1,12 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.TransferenciaDTO; -import java.math.BigDecimal; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class TransferenciaRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java index 269dfa0..e99194e 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java @@ -1,9 +1,11 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.ValorInicialDoDonoNaContaPatrimonioDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ValorInicialDoDonoNaContaPatrimonioRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/service/CrudService.java b/src/main/java/br/edu/ifrn/conta/service/CrudService.java index 2e9f8be..69758b9 100644 --- a/src/main/java/br/edu/ifrn/conta/service/CrudService.java +++ b/src/main/java/br/edu/ifrn/conta/service/CrudService.java @@ -2,6 +2,7 @@ import java.io.Serializable; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.data.repository.CrudRepository; @@ -12,6 +13,7 @@ * @param entity * @param entity id */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Transactional(readOnly = true) public class CrudService { diff --git a/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java b/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java index 8c74e96..0a6a01f 100644 --- a/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java +++ b/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java @@ -8,6 +8,8 @@ import br.edu.ifrn.conta.domain.ContaPatrimonio; import br.edu.ifrn.conta.domain.Dono; import br.edu.ifrn.conta.domain.Lancamento; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; @@ -16,6 +18,7 @@ /** * Service of transferencia. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Service public class TransferenciaService { diff --git a/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java b/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java index 6de8721..05088a8 100644 --- a/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java +++ b/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java @@ -6,6 +6,7 @@ import br.edu.ifrn.conta.domain.Dono; import static br.edu.ifrn.conta.util.DonoConstants.MAMAE; import static br.edu.ifrn.conta.util.DonoConstants.PAPAI; +import static br.edu.ifrn.conta.util.DonoConstants.TITIA; import java.util.Optional; @Component @@ -31,4 +32,8 @@ public Dono papai() { public Dono mamae() { return dono(MAMAE); } + + public Dono titia() { + return dono(TITIA); + } } diff --git a/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java b/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java index db939e9..4919c1b 100644 --- a/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java +++ b/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java @@ -49,11 +49,12 @@ public void countByDescricao() { // cria o ambiente de teste this.donoFactory.papai(); this.donoFactory.mamae(); + this.donoFactory.titia(); // executa a operacao a ser testada // verifica o efeito da execucao da operacao a ser testada assertThat(this.donoRepository.countByDescricaoContains("a")) - .isEqualTo(2); + .isEqualTo(3); } @Test diff --git a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java index e73f239..42b1c93 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java @@ -2,11 +2,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class CategoriaRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java index 709cb7f..9b083c2 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java @@ -3,6 +3,7 @@ import br.edu.ifrn.conta.ContaApplication; import br.edu.ifrn.conta.dto.CategoriaDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -14,12 +15,13 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class CategoriaRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java index 4326474..09ced83 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java @@ -3,11 +3,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import br.edu.ifrn.conta.dto.ContaCreditoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ContaCreditoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java index 49666ae..1cf6976 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java @@ -4,6 +4,7 @@ import br.edu.ifrn.conta.dto.ContaCreditoDTO; import static br.edu.ifrn.conta.util.CategoriaConstants.SALARIO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -15,12 +16,13 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaCreditoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java index 6c02cda..d73bbae 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java @@ -3,11 +3,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import br.edu.ifrn.conta.dto.ContaDebitoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ContaDebitoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java index 5c0deb8..543bbcf 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java @@ -4,6 +4,7 @@ import br.edu.ifrn.conta.dto.ContaDebitoDTO; import static br.edu.ifrn.conta.util.CategoriaConstants.TRANSPORTE; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -15,12 +16,13 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaDebitoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java index 1ffc54f..19bd1f1 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java @@ -3,11 +3,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import br.edu.ifrn.conta.dto.ContaPatrimonioDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ContaPatrimonioRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java index cfeaa75..be918de 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java @@ -4,6 +4,7 @@ import br.edu.ifrn.conta.dto.ContaPatrimonioDTO; import static br.edu.ifrn.conta.util.CategoriaConstants.BANCO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -15,12 +16,13 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaPatrimonioRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java index 97b8d7e..d6ab8b0 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java @@ -2,11 +2,13 @@ import br.edu.ifrn.conta.dto.DonoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class DonoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java index 2cf61ae..3b547c5 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java @@ -3,6 +3,7 @@ import br.edu.ifrn.conta.ContaApplication; import br.edu.ifrn.conta.dto.DonoDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -14,12 +15,13 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class DonoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java index 0da4cdc..94ff07d 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.LancamentoDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class LancamentoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java index 7db3195..8710f7e 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java @@ -11,6 +11,7 @@ import java.time.LocalDateTime; import static org.assertj.core.api.Assertions.assertThat; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -20,12 +21,13 @@ import org.springframework.boot.test.context.SpringBootTest; import org.springframework.test.context.junit.jupiter.SpringExtension; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class LancamentoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java index 7f49c05..2bc40ad 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.LancamentoDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class SaldoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java index f0a68b8..d517117 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java @@ -18,6 +18,7 @@ import java.time.LocalDateTime; import static org.assertj.core.api.Assertions.assertThat; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -28,12 +29,13 @@ import org.springframework.test.context.junit.jupiter.SpringExtension; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class SaldoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java index 7b3ddaa..5a79b05 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.TransferenciaDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class TransferenciaRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java index 606d14c..ba69d88 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java @@ -12,6 +12,7 @@ import java.math.BigDecimal; import static org.assertj.core.api.Assertions.assertThat; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -22,12 +23,13 @@ import org.springframework.test.context.junit.jupiter.SpringExtension; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class TransferenciaRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java index d32c7db..5137c3d 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.ValorInicialDoDonoNaContaPatrimonioDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ValorInicialDoDonoNaContaPatrimonioRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java index f06cdb6..221ec87 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java @@ -8,6 +8,7 @@ import static br.edu.ifrn.conta.util.ContaPatrimonioConstants.POUPANCA; import static br.edu.ifrn.conta.util.DonoConstants.MAMAE; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -19,12 +20,13 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ValorInicialDoDonoNaContaPatrimonioRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port;