From 48eb63dd150b0ffaa7a80b079ea1570dd96b0c54 Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Wed, 19 Apr 2023 19:51:44 +0000 Subject: [PATCH 1/7] configure spotbugs --- pom.xml | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/pom.xml b/pom.xml index 8122a32..acc1a05 100644 --- a/pom.xml +++ b/pom.xml @@ -21,6 +21,8 @@ 5.0.5 5.0.0 1.1.3 + + 4.7.3.4 @@ -138,6 +140,17 @@ + + com.github.spotbugs + spotbugs-maven-plugin + ${spotbugs-maven-plugin.version} + + true + true + Max + true + + @@ -153,6 +166,27 @@ + + + check-spotbugs + + + + com.github.spotbugs + spotbugs-maven-plugin + + + + check + + + + + + + + + conta Conta do Desenvolvimento de Sistemas Corporativos https://github.com/persapiens/conta From b40d5fdce3577d81d909b9a946f954a580e6c056 Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Wed, 19 Apr 2023 20:14:58 +0000 Subject: [PATCH 2/7] add spotbugs-annotatios dependency to ignore some spotbugs issues --- pom.xml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pom.xml b/pom.xml index acc1a05..15f7261 100644 --- a/pom.xml +++ b/pom.xml @@ -23,6 +23,7 @@ 1.1.3 4.7.3.4 + 3.0.1 @@ -53,6 +54,11 @@ ${querydsl.version} jakarta + + com.google.code.findbugs + findbugs-annotations + ${findbugs-annotations.version} + @@ -119,6 +125,10 @@ querydsl-jpa jakarta + + com.google.code.findbugs + findbugs-annotations + From 3c70d31052c84c59233c4f8fdaba0b6a4ecc4c07 Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Wed, 19 Apr 2023 21:03:19 +0000 Subject: [PATCH 3/7] solving EI_EXPOSE_REP and EI_EXPOSE_REP2 spotbugs errors --- .../br/edu/ifrn/conta/dominio/Categoria.java | 3 +++ .../java/br/edu/ifrn/conta/dominio/Conta.java | 3 +++ .../br/edu/ifrn/conta/dominio/ContaCredito.java | 3 +++ .../br/edu/ifrn/conta/dominio/ContaDebito.java | 3 +++ .../edu/ifrn/conta/dominio/ContaPatrimonio.java | 4 ++++ .../java/br/edu/ifrn/conta/dominio/Dono.java | 4 ++++ .../br/edu/ifrn/conta/dominio/Lancamento.java | 10 ++++++++-- .../ValorInicialDoDonoNaContaPatrimonio.java | 5 +++++ .../persistencia/LancamentoRepositoryImpl.java | 3 +++ .../br/edu/ifrn/conta/servico/CrudServico.java | 3 +++ .../ifrn/conta/servico/LancamentoServico.java | 4 ++-- .../br/edu/ifrn/conta/visao/crud/CrudMBean.java | 5 +++++ .../conta/visao/options/ContaEntradaOptions.java | 4 ++++ .../conta/visao/options/ContaSaidaOptions.java | 4 ++++ .../br/edu/ifrn/conta/visao/options/Options.java | 8 ++++++++ .../edu/ifrn/conta/dominio/LancamentoTests.java | 16 ++++++++-------- .../conta/persistencia/LancamentoFabrica.java | 4 ++-- .../ifrn/conta/servico/LancamentoServicoIT.java | 6 +++--- 18 files changed, 75 insertions(+), 17 deletions(-) diff --git a/src/main/java/br/edu/ifrn/conta/dominio/Categoria.java b/src/main/java/br/edu/ifrn/conta/dominio/Categoria.java index 7ae41b3..d6c04ae 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/Categoria.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/Categoria.java @@ -37,6 +37,8 @@ import lombok.Singular; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Categoria entity. * @author Marcelo Fernandes @@ -61,6 +63,7 @@ public class Categoria implements Serializable, Comparable { @Column(nullable = false, unique = true) private String descricao; + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Singular @OneToMany(mappedBy = "categoria") private Set contas; diff --git a/src/main/java/br/edu/ifrn/conta/dominio/Conta.java b/src/main/java/br/edu/ifrn/conta/dominio/Conta.java index 7853ff7..f201a2b 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/Conta.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/Conta.java @@ -39,6 +39,8 @@ import lombok.Setter; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Conta abstrata entity. * @author Marcelo Fernandes @@ -63,6 +65,7 @@ public abstract class Conta implements Serializable, Comparable { @Column(nullable = false, unique = true) private String descricao; + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @NonNull @ManyToOne @JoinColumn(nullable = false, foreignKey = @ForeignKey(name = "fk_conta_categoria")) diff --git a/src/main/java/br/edu/ifrn/conta/dominio/ContaCredito.java b/src/main/java/br/edu/ifrn/conta/dominio/ContaCredito.java index da7f98f..14d67dd 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/ContaCredito.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/ContaCredito.java @@ -26,10 +26,13 @@ import lombok.Setter; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Conta Credito entity. * @author Marcelo Fernandes */ +@SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Getter @Setter @ToString(callSuper = true) diff --git a/src/main/java/br/edu/ifrn/conta/dominio/ContaDebito.java b/src/main/java/br/edu/ifrn/conta/dominio/ContaDebito.java index 437c75c..5fee9cf 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/ContaDebito.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/ContaDebito.java @@ -26,10 +26,13 @@ import lombok.Setter; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Conta Debito entity. * @author Marcelo Fernandes */ +@SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Getter @Setter @ToString(callSuper = true) diff --git a/src/main/java/br/edu/ifrn/conta/dominio/ContaPatrimonio.java b/src/main/java/br/edu/ifrn/conta/dominio/ContaPatrimonio.java index 9e9a4b7..7a9ff92 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/ContaPatrimonio.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/ContaPatrimonio.java @@ -30,10 +30,13 @@ import lombok.Singular; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Conta Patrimonio entity. * @author Marcelo Fernandes */ +@SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Getter @Setter @ToString(callSuper = true, exclude = "valoresIniciaisDosDonos") @@ -50,6 +53,7 @@ public ContaPatrimonio(@Singular("valorInicialDoDono") Set valoresIniciaisDosDonos; diff --git a/src/main/java/br/edu/ifrn/conta/dominio/Dono.java b/src/main/java/br/edu/ifrn/conta/dominio/Dono.java index a5d373c..6bbe2d9 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/Dono.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/Dono.java @@ -37,6 +37,8 @@ import lombok.Singular; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Dono entity. * @author Marcelo Fernandes @@ -61,10 +63,12 @@ public class Dono implements Serializable, Comparable { @Column(nullable = false, unique = true) private String descricao; + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Singular @OneToMany(mappedBy = "dono") private Set lancamentos; + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Singular("valorInicialNaContaPatrimonio") @OneToMany(mappedBy = "dono") private Set valoresIniciaisNasContasPatrimonio; diff --git a/src/main/java/br/edu/ifrn/conta/dominio/Lancamento.java b/src/main/java/br/edu/ifrn/conta/dominio/Lancamento.java index 83bd29a..da9ce45 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/Lancamento.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/Lancamento.java @@ -18,7 +18,7 @@ import java.io.Serializable; import java.math.BigDecimal; -import java.util.Date; +import java.time.LocalDateTime; import jakarta.persistence.Column; import jakarta.persistence.Entity; @@ -41,10 +41,13 @@ import lombok.Setter; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Lancamento entity. * @author Marcelo Fernandes */ +@SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Getter @Setter @ToString @@ -62,14 +65,17 @@ public class Lancamento implements Serializable, Comparable { @GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "ID_SEQUENCE") private Long id; + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ManyToOne @JoinColumn(nullable = false, foreignKey = @ForeignKey(name = "fk_lancamento_dono")) private Dono dono; + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ManyToOne @JoinColumn(nullable = false, foreignKey = @ForeignKey(name = "fk_lancamento_contaEntrada")) private Conta contaEntrada; + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ManyToOne @JoinColumn(nullable = false, foreignKey = @ForeignKey(name = "fk_lancamento_contaSaida")) private Conta contaSaida; @@ -79,7 +85,7 @@ public class Lancamento implements Serializable, Comparable { @Temporal(TemporalType.TIMESTAMP) @Column(nullable = false) - private Date data; + private LocalDateTime data; private String descricao; diff --git a/src/main/java/br/edu/ifrn/conta/dominio/ValorInicialDoDonoNaContaPatrimonio.java b/src/main/java/br/edu/ifrn/conta/dominio/ValorInicialDoDonoNaContaPatrimonio.java index cd7b8d4..b904bb4 100644 --- a/src/main/java/br/edu/ifrn/conta/dominio/ValorInicialDoDonoNaContaPatrimonio.java +++ b/src/main/java/br/edu/ifrn/conta/dominio/ValorInicialDoDonoNaContaPatrimonio.java @@ -38,10 +38,13 @@ import lombok.Setter; import lombok.ToString; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Valor Inicial do Dono na Conta Patrimonio entity. * @author Marcelo Fernandes */ +@SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Getter @Setter @ToString @@ -62,10 +65,12 @@ public class ValorInicialDoDonoNaContaPatrimonio implements Serializable, Compar @Column(nullable = false) private BigDecimal valorInicial; + @SuppressFBWarnings({"EI_EXPOSE_REP"}) @ManyToOne @JoinColumn(nullable = false, foreignKey = @ForeignKey(name = "fk_valorInicial_dono")) private Dono dono; + @SuppressFBWarnings({"EI_EXPOSE_REP"}) @ManyToOne @JoinColumn(nullable = false, foreignKey = @ForeignKey(name = "fk_valorInicial_contaPatrimonio")) private ContaPatrimonio contaPatrimonio; diff --git a/src/main/java/br/edu/ifrn/conta/persistencia/LancamentoRepositoryImpl.java b/src/main/java/br/edu/ifrn/conta/persistencia/LancamentoRepositoryImpl.java index cceb6ca..ed42d4a 100644 --- a/src/main/java/br/edu/ifrn/conta/persistencia/LancamentoRepositoryImpl.java +++ b/src/main/java/br/edu/ifrn/conta/persistencia/LancamentoRepositoryImpl.java @@ -27,6 +27,8 @@ import com.querydsl.jpa.JPQLQueryFactory; import com.querydsl.jpa.impl.JPAQueryFactory; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * CrudRepository customizado. * @author Marcelo Fernandes @@ -37,6 +39,7 @@ public class LancamentoRepositoryImpl implements LancamentoRepositoryCustom { private final ValorInicialDoDonoNaContaPatrimonioRepository valorInicialDoDonoNaContaPatrimonioRepository; + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public LancamentoRepositoryImpl(EntityManager entityManager, ValorInicialDoDonoNaContaPatrimonioRepository valorInicialDoDonoNaContaPatrimonioRepository) { this.entityManager = entityManager; diff --git a/src/main/java/br/edu/ifrn/conta/servico/CrudServico.java b/src/main/java/br/edu/ifrn/conta/servico/CrudServico.java index 4894107..ced65b6 100644 --- a/src/main/java/br/edu/ifrn/conta/servico/CrudServico.java +++ b/src/main/java/br/edu/ifrn/conta/servico/CrudServico.java @@ -24,6 +24,8 @@ import org.springframework.data.repository.CrudRepository; import org.springframework.transaction.annotation.Transactional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Implementacao padrao de servico crud delegando a implementacao para o * repositorio. @@ -36,6 +38,7 @@ public class CrudServico { private CrudRepository repository; + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public void setRepositorio(CrudRepository repository) { this.repository = repository; diff --git a/src/main/java/br/edu/ifrn/conta/servico/LancamentoServico.java b/src/main/java/br/edu/ifrn/conta/servico/LancamentoServico.java index f82da57..d54c1f1 100644 --- a/src/main/java/br/edu/ifrn/conta/servico/LancamentoServico.java +++ b/src/main/java/br/edu/ifrn/conta/servico/LancamentoServico.java @@ -17,7 +17,7 @@ package br.edu.ifrn.conta.servico; import java.math.BigDecimal; -import java.util.Date; +import java.time.LocalDateTime; import jakarta.inject.Inject; import jakarta.inject.Named; @@ -66,7 +66,7 @@ public void transferir(BigDecimal valor, Dono donoDebito, ContaDebito contaDebit + donoDebito + " = " + donoCredito); } - Date data = new Date(); + LocalDateTime data = LocalDateTime.now(); Lancamento lancamentoComDespesa = Lancamento.builder() .contaEntrada(contaDebito) diff --git a/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java b/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java index fdce252..aa3a248 100644 --- a/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java +++ b/src/main/java/br/edu/ifrn/conta/visao/crud/CrudMBean.java @@ -30,6 +30,8 @@ import lombok.Setter; import org.primefaces.PrimeFaces; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Managed Bean abstrato de crud. * @param tipo do bean @@ -64,6 +66,7 @@ public abstract class CrudMBean private CrudServico service; + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public void setService(CrudServico service) { this.service = service; @@ -79,6 +82,7 @@ public CrudMBean() { setVisualizationMode(LIST); } + @SuppressFBWarnings({"EI_EXPOSE_REP"}) public final List getBeanList() { try { if (this.beanList == null) { @@ -91,6 +95,7 @@ public final List getBeanList() { return this.beanList; } + @SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter private List filteredBeanList = null; diff --git a/src/main/java/br/edu/ifrn/conta/visao/options/ContaEntradaOptions.java b/src/main/java/br/edu/ifrn/conta/visao/options/ContaEntradaOptions.java index 0b3c384..52d6ad1 100644 --- a/src/main/java/br/edu/ifrn/conta/visao/options/ContaEntradaOptions.java +++ b/src/main/java/br/edu/ifrn/conta/visao/options/ContaEntradaOptions.java @@ -27,6 +27,8 @@ import br.edu.ifrn.conta.servico.ContaDebitoServico; import br.edu.ifrn.conta.servico.ContaPatrimonioServico; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Options de ContaEntrada. * @author Marcelo Fernandes @@ -41,11 +43,13 @@ public class ContaEntradaOptions extends Options { private transient ContaPatrimonioServico contaPatrimonioServico; + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public void setContaDebitoServico(ContaDebitoServico contaDebitoServico) { this.contaDebitoServico = contaDebitoServico; } + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public void setContaPatrimonioServico(ContaPatrimonioServico contaPatrimonioServico) { this.contaPatrimonioServico = contaPatrimonioServico; diff --git a/src/main/java/br/edu/ifrn/conta/visao/options/ContaSaidaOptions.java b/src/main/java/br/edu/ifrn/conta/visao/options/ContaSaidaOptions.java index 948e2d3..4a442be 100644 --- a/src/main/java/br/edu/ifrn/conta/visao/options/ContaSaidaOptions.java +++ b/src/main/java/br/edu/ifrn/conta/visao/options/ContaSaidaOptions.java @@ -27,6 +27,8 @@ import br.edu.ifrn.conta.servico.ContaCreditoServico; import br.edu.ifrn.conta.servico.ContaPatrimonioServico; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Options de ContaSaida. * @author Marcelo Fernandes @@ -41,11 +43,13 @@ public class ContaSaidaOptions extends Options { private transient ContaPatrimonioServico contaPatrimonioServico; + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public void setContaCreditoServico(ContaCreditoServico contaCreditoServico) { this.contaCreditoServico = contaCreditoServico; } + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public void setContaPatrimonioServico(ContaPatrimonioServico contaPatrimonioServico) { this.contaPatrimonioServico = contaPatrimonioServico; diff --git a/src/main/java/br/edu/ifrn/conta/visao/options/Options.java b/src/main/java/br/edu/ifrn/conta/visao/options/Options.java index 34de01d..19b3767 100644 --- a/src/main/java/br/edu/ifrn/conta/visao/options/Options.java +++ b/src/main/java/br/edu/ifrn/conta/visao/options/Options.java @@ -28,6 +28,8 @@ import br.edu.ifrn.conta.visao.AbstractMBean; import org.omnifaces.converter.ListConverter; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + /** * Options de entidades. * @param tipo da chave da entidade. @@ -40,6 +42,7 @@ public abstract class Options extends AbstractMBean private CrudServico service; + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) @Inject public void setService(CrudServico service) { this.service = service; @@ -81,6 +84,7 @@ protected void clear() { private transient ListConverter listConverter; + @SuppressFBWarnings({"EI_EXPOSE_REP"}) public Converter getListConverter() { verify(); @@ -94,12 +98,14 @@ public Converter getListConverter() { private List list; + @SuppressFBWarnings({"EI_EXPOSE_REP2"}) public void setList(List list) { this.list = list; clear(); } + @SuppressFBWarnings({"EI_EXPOSE_REP"}) public final List getList() { verify(); @@ -117,6 +123,7 @@ protected final List createOptions() { return result; } + @SuppressFBWarnings({"EI_EXPOSE_REP"}) public final List getOptions() { verify(); @@ -132,6 +139,7 @@ protected final List createEmptyOptions(List options) { return result; } + @SuppressFBWarnings({"EI_EXPOSE_REP"}) public final List getEmptyOptions() { verify(); diff --git a/src/test/java/br/edu/ifrn/conta/dominio/LancamentoTests.java b/src/test/java/br/edu/ifrn/conta/dominio/LancamentoTests.java index 9ed40b0..5b50f6b 100644 --- a/src/test/java/br/edu/ifrn/conta/dominio/LancamentoTests.java +++ b/src/test/java/br/edu/ifrn/conta/dominio/LancamentoTests.java @@ -17,7 +17,7 @@ package br.edu.ifrn.conta.dominio; import java.math.BigDecimal; -import java.util.Date; +import java.time.LocalDateTime; import java.util.Set; import java.util.TreeSet; @@ -35,7 +35,7 @@ public class LancamentoTests { private static final String CARTEIRA = "carteira"; private static final String DESCRICAO_POSTO_PREDILETO = "comprar gasolina no Posto Predileto"; - private Lancamento lancamento(Date data, BigDecimal valor, String descricaoDono, String descricao) { + private Lancamento lancamento(LocalDateTime data, BigDecimal valor, String descricaoDono, String descricao) { return Lancamento.builder() .descricao(descricao) .dono(Dono.builder().descricao(descricaoDono).build()) @@ -52,7 +52,7 @@ private Lancamento lancamento(Date data, BigDecimal valor, String descricaoDono, @Test public void donoValorDataContaEntradaContaSaidaIguaisComDescricaoDiferente() { - Date hoje = new Date(); + LocalDateTime hoje = LocalDateTime.now(); Lancamento lancamentoGasolina1 = lancamento(hoje, new BigDecimal(100), PAPAI, DESCRICAO_POSTO_PREDILETO); Lancamento lancamentoGasolina2 = lancamento(hoje, new BigDecimal(100), PAPAI, "outra descrição qualquer"); @@ -62,7 +62,7 @@ public void donoValorDataContaEntradaContaSaidaIguaisComDescricaoDiferente() { @Test public void donoValorDataContaEntradaContaSaidaDescricaoIguaisComValorDiferente() { - Date hoje = new Date(); + LocalDateTime hoje = LocalDateTime.now(); Lancamento lancamentoGasolina1 = lancamento(hoje, new BigDecimal(200), PAPAI, DESCRICAO_POSTO_PREDILETO); Lancamento lancamentoGasolina2 = lancamento(hoje, new BigDecimal(100), PAPAI, DESCRICAO_POSTO_PREDILETO); @@ -74,8 +74,8 @@ public void donoValorDataContaEntradaContaSaidaDescricaoIguaisComValorDiferente( public void compareToComDatasDiferentes() { Set lancamentos = new TreeSet<>(); - Lancamento lancamentoGasolina1 = lancamento(new Date(), new BigDecimal(100), PAPAI, DESCRICAO_POSTO_PREDILETO); - Lancamento lancamentoGasolina2 = lancamento(new Date(), new BigDecimal(100), PAPAI, DESCRICAO_POSTO_PREDILETO); + Lancamento lancamentoGasolina1 = lancamento(LocalDateTime.now(), new BigDecimal(100), PAPAI, DESCRICAO_POSTO_PREDILETO); + Lancamento lancamentoGasolina2 = lancamento(LocalDateTime.now(), new BigDecimal(100), PAPAI, DESCRICAO_POSTO_PREDILETO); lancamentos.add(lancamentoGasolina2); lancamentos.add(lancamentoGasolina1); @@ -84,7 +84,7 @@ public void compareToComDatasDiferentes() { @Test public void compareToComValoresDiferentes() { - Date hoje = new Date(); + LocalDateTime hoje = LocalDateTime.now(); Set lancamentos = new TreeSet<>(); @@ -98,7 +98,7 @@ public void compareToComValoresDiferentes() { @Test public void compareToComDonosDiferentes() { - Date hoje = new Date(); + LocalDateTime hoje = LocalDateTime.now(); Set lancamentos = new TreeSet<>(); diff --git a/src/test/java/br/edu/ifrn/conta/persistencia/LancamentoFabrica.java b/src/test/java/br/edu/ifrn/conta/persistencia/LancamentoFabrica.java index 0f4e457..f006a60 100644 --- a/src/test/java/br/edu/ifrn/conta/persistencia/LancamentoFabrica.java +++ b/src/test/java/br/edu/ifrn/conta/persistencia/LancamentoFabrica.java @@ -17,7 +17,7 @@ package br.edu.ifrn.conta.persistencia; import java.math.BigDecimal; -import java.util.Date; +import java.time.LocalDateTime; import jakarta.inject.Inject; import jakarta.inject.Named; @@ -36,7 +36,7 @@ public Lancamento lancamento(Dono dono, Conta contaEntrada, Conta contaSaida, Bi Lancamento lancamento = Lancamento.builder() .contaEntrada(contaEntrada) .contaSaida(contaSaida) - .data(new Date()) + .data(LocalDateTime.now()) .dono(dono) .valor(valor.setScale(2)) .build(); diff --git a/src/test/java/br/edu/ifrn/conta/servico/LancamentoServicoIT.java b/src/test/java/br/edu/ifrn/conta/servico/LancamentoServicoIT.java index 38d4627..152c202 100644 --- a/src/test/java/br/edu/ifrn/conta/servico/LancamentoServicoIT.java +++ b/src/test/java/br/edu/ifrn/conta/servico/LancamentoServicoIT.java @@ -17,7 +17,7 @@ package br.edu.ifrn.conta.servico; import java.math.BigDecimal; -import java.util.Date; +import java.time.LocalDateTime; import jakarta.inject.Inject; @@ -84,7 +84,7 @@ public void lancamentoComContaEntradaInvalida() { .contaEntrada(this.contaCreditoFabrica.estagio()) .contaSaida(this.contaPatrimonioFabrica.poupanca()) .valor(BigDecimal.TEN) - .data(new Date()) + .data(LocalDateTime.now()) .dono(this.donoFabrica.papai()) .build(); @@ -101,7 +101,7 @@ public void lancamentoComContaSaidaInvalida() { .contaEntrada(this.contaPatrimonioFabrica.poupanca()) .contaSaida(this.contaDebitoFabrica.gasolina()) .valor(BigDecimal.TEN) - .data(new Date()) + .data(LocalDateTime.now()) .dono(this.donoFabrica.papai()) .build(); From 87d82a5946f1f540e7c9af499860d1bd4bfc8d5c Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Thu, 25 Apr 2024 17:08:50 +0000 Subject: [PATCH 4/7] fix EI_EXPOSE_REP, EI_EXPOSE_REP2 spotbugs errors just skipping the error with annotations. --- src/main/java/br/edu/ifrn/conta/domain/Categoria.java | 2 ++ src/main/java/br/edu/ifrn/conta/domain/Conta.java | 2 ++ src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java | 2 ++ src/main/java/br/edu/ifrn/conta/domain/Dono.java | 2 ++ src/main/java/br/edu/ifrn/conta/domain/Lancamento.java | 2 ++ .../ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java | 2 ++ src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java | 3 +++ src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java | 3 +++ .../ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java | 3 +++ .../java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java | 2 ++ .../br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java | 2 ++ .../br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java | 2 ++ .../edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java | 2 ++ src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java | 2 ++ .../br/edu/ifrn/conta/restclient/LancamentoRestClient.java | 2 ++ .../java/br/edu/ifrn/conta/restclient/RestClientHelper.java | 2 ++ .../java/br/edu/ifrn/conta/restclient/SaldoRestClient.java | 2 ++ .../br/edu/ifrn/conta/restclient/TransferenciaRestClient.java | 3 ++- .../ValorInicialDoDonoNaContaPatrimonioRestClient.java | 2 ++ src/main/java/br/edu/ifrn/conta/service/CrudService.java | 2 ++ .../java/br/edu/ifrn/conta/service/TransferenciaService.java | 3 +++ .../edu/ifrn/conta/restclient/CategoriaRestClientFactory.java | 2 ++ .../br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java | 2 ++ .../ifrn/conta/restclient/ContaCreditoRestClientFactory.java | 2 ++ .../br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java | 2 ++ .../ifrn/conta/restclient/ContaDebitoRestClientFactory.java | 2 ++ .../br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java | 2 ++ .../conta/restclient/ContaPatrimonioRestClientFactory.java | 2 ++ .../edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java | 2 ++ .../br/edu/ifrn/conta/restclient/DonoRestClientFactory.java | 2 ++ .../java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java | 2 ++ .../edu/ifrn/conta/restclient/LancamentoRestClientFactory.java | 2 ++ .../br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java | 2 ++ .../br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java | 2 ++ .../java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java | 2 ++ .../ifrn/conta/restclient/TransferenciaRestClientFactory.java | 2 ++ .../edu/ifrn/conta/restclient/TransferenciaRestClientIT.java | 2 ++ .../ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java | 2 ++ .../ValorInicialDoDonoNaContaPatrimonioRestClientIT.java | 2 ++ 39 files changed, 82 insertions(+), 1 deletion(-) diff --git a/src/main/java/br/edu/ifrn/conta/domain/Categoria.java b/src/main/java/br/edu/ifrn/conta/domain/Categoria.java index ae889d3..bfe566b 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Categoria.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Categoria.java @@ -3,6 +3,7 @@ import java.io.Serializable; import java.util.Set; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Column; import jakarta.persistence.Entity; import jakarta.persistence.GeneratedValue; @@ -24,6 +25,7 @@ /** * Categoria entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString(exclude = "contas") diff --git a/src/main/java/br/edu/ifrn/conta/domain/Conta.java b/src/main/java/br/edu/ifrn/conta/domain/Conta.java index 090ea31..1880d06 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Conta.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Conta.java @@ -15,6 +15,7 @@ import jakarta.persistence.SequenceGenerator; import java.util.Comparator; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.AllArgsConstructor; import lombok.EqualsAndHashCode; import lombok.Getter; @@ -27,6 +28,7 @@ /** * Conta abstract entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Getter @Setter diff --git a/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java b/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java index d0a29ac..8bdc94d 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java +++ b/src/main/java/br/edu/ifrn/conta/domain/ContaPatrimonio.java @@ -2,6 +2,7 @@ import java.util.Set; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Entity; import jakarta.persistence.OneToMany; @@ -17,6 +18,7 @@ /** * Conta Patrimonio entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Getter @Setter diff --git a/src/main/java/br/edu/ifrn/conta/domain/Dono.java b/src/main/java/br/edu/ifrn/conta/domain/Dono.java index 5a608e9..318f581 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Dono.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Dono.java @@ -3,6 +3,7 @@ import java.io.Serializable; import java.util.Set; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Column; import jakarta.persistence.Entity; import jakarta.persistence.GeneratedValue; @@ -24,6 +25,7 @@ /** * Dono entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString(of = "descricao") diff --git a/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java b/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java index e69128a..37d426f 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java +++ b/src/main/java/br/edu/ifrn/conta/domain/Lancamento.java @@ -5,6 +5,7 @@ import java.time.LocalDateTime; import java.util.Comparator; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import jakarta.persistence.Column; import jakarta.persistence.Entity; import jakarta.persistence.ForeignKey; @@ -27,6 +28,7 @@ /** * Lancamento entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString diff --git a/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java b/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java index 4c75caa..1a2cd88 100644 --- a/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java +++ b/src/main/java/br/edu/ifrn/conta/domain/ValorInicialDoDonoNaContaPatrimonio.java @@ -14,6 +14,7 @@ import jakarta.persistence.SequenceGenerator; import java.util.Comparator; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.AccessLevel; import lombok.AllArgsConstructor; import lombok.experimental.SuperBuilder; @@ -26,6 +27,7 @@ /** * Valor Inicial do Dono na Conta Patrimonio entity. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Getter @Setter @ToString diff --git a/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java b/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java index 0344b2d..448d32c 100644 --- a/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java +++ b/src/main/java/br/edu/ifrn/conta/dto/ContaDTO.java @@ -1,6 +1,8 @@ package br.edu.ifrn.conta.dto; import java.io.Serializable; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.Data; import lombok.NoArgsConstructor; import lombok.ToString; @@ -9,6 +11,7 @@ /** * DTO interface. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data @ToString diff --git a/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java b/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java index a5a62bb..02afe89 100644 --- a/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java +++ b/src/main/java/br/edu/ifrn/conta/dto/LancamentoDTO.java @@ -3,6 +3,8 @@ import java.io.Serializable; import java.math.BigDecimal; import java.time.LocalDateTime; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import lombok.NoArgsConstructor; @@ -11,6 +13,7 @@ /** * DTO interface. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data @ToString diff --git a/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java b/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java index 635d394..8ce521d 100644 --- a/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java +++ b/src/main/java/br/edu/ifrn/conta/dto/ValorInicialDoDonoNaContaPatrimonioDTO.java @@ -2,6 +2,8 @@ import java.io.Serializable; import java.math.BigDecimal; + +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import lombok.NoArgsConstructor; @@ -10,6 +12,7 @@ /** * DTO interface. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data @ToString diff --git a/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java index 78fa97e..cbba756 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/CategoriaRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class CategoriaRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java index ee84f3c..6219ff1 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.ContaCreditoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ContaCreditoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java index be12ae7..bbfcbc2 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.ContaDebitoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ContaDebitoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java index 5f8938a..f527048 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.ContaPatrimonioDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ContaPatrimonioRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java index 37d31cc..d0ca317 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/DonoRestClient.java @@ -2,9 +2,11 @@ import br.edu.ifrn.conta.dto.DonoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class DonoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java index 6c3f65d..765144d 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/LancamentoRestClient.java @@ -2,10 +2,12 @@ import br.edu.ifrn.conta.dto.LancamentoDTO; import java.math.BigDecimal; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class LancamentoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java b/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java index 990ab9f..20c3c03 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/RestClientHelper.java @@ -3,12 +3,14 @@ import java.net.URI; import lombok.experimental.SuperBuilder; import lombok.Data; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.springframework.core.ParameterizedTypeReference; import org.springframework.http.HttpEntity; import org.springframework.http.HttpMethod; import org.springframework.web.client.RestTemplate; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class RestClientHelper { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java index f909890..ae6acc6 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/SaldoRestClient.java @@ -2,10 +2,12 @@ import br.edu.ifrn.conta.dto.LancamentoDTO; import java.math.BigDecimal; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class SaldoRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java index 0561186..4789baf 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/TransferenciaRestClient.java @@ -1,11 +1,12 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.TransferenciaDTO; -import java.math.BigDecimal; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.util.UriComponentsBuilder; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class TransferenciaRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java b/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java index 269dfa0..e99194e 100644 --- a/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java +++ b/src/main/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClient.java @@ -1,9 +1,11 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.ValorInicialDoDonoNaContaPatrimonioDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Data @SuperBuilder public class ValorInicialDoDonoNaContaPatrimonioRestClient { diff --git a/src/main/java/br/edu/ifrn/conta/service/CrudService.java b/src/main/java/br/edu/ifrn/conta/service/CrudService.java index 2e9f8be..69758b9 100644 --- a/src/main/java/br/edu/ifrn/conta/service/CrudService.java +++ b/src/main/java/br/edu/ifrn/conta/service/CrudService.java @@ -2,6 +2,7 @@ import java.io.Serializable; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.data.repository.CrudRepository; @@ -12,6 +13,7 @@ * @param entity * @param entity id */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Transactional(readOnly = true) public class CrudService { diff --git a/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java b/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java index 8c74e96..0a6a01f 100644 --- a/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java +++ b/src/main/java/br/edu/ifrn/conta/service/TransferenciaService.java @@ -8,6 +8,8 @@ import br.edu.ifrn.conta.domain.ContaPatrimonio; import br.edu.ifrn.conta.domain.Dono; import br.edu.ifrn.conta.domain.Lancamento; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; + import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Service; @@ -16,6 +18,7 @@ /** * Service of transferencia. */ +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @Service public class TransferenciaService { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java index e73f239..42b1c93 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientFactory.java @@ -2,11 +2,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class CategoriaRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java index 709cb7f..970f823 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java @@ -3,6 +3,7 @@ import br.edu.ifrn.conta.ContaApplication; import br.edu.ifrn.conta.dto.CategoriaDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -14,6 +15,7 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class CategoriaRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java index 4326474..09ced83 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientFactory.java @@ -3,11 +3,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import br.edu.ifrn.conta.dto.ContaCreditoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ContaCreditoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java index 49666ae..a5c6a98 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java @@ -4,6 +4,7 @@ import br.edu.ifrn.conta.dto.ContaCreditoDTO; import static br.edu.ifrn.conta.util.CategoriaConstants.SALARIO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -15,6 +16,7 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaCreditoRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java index 6c02cda..d73bbae 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientFactory.java @@ -3,11 +3,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import br.edu.ifrn.conta.dto.ContaDebitoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ContaDebitoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java index 5c0deb8..4fed2c7 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java @@ -4,6 +4,7 @@ import br.edu.ifrn.conta.dto.ContaDebitoDTO; import static br.edu.ifrn.conta.util.CategoriaConstants.TRANSPORTE; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -15,6 +16,7 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaDebitoRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java index 1ffc54f..19bd1f1 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientFactory.java @@ -3,11 +3,13 @@ import br.edu.ifrn.conta.dto.CategoriaDTO; import br.edu.ifrn.conta.dto.ContaPatrimonioDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ContaPatrimonioRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java index cfeaa75..a5a6aaf 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java @@ -4,6 +4,7 @@ import br.edu.ifrn.conta.dto.ContaPatrimonioDTO; import static br.edu.ifrn.conta.util.CategoriaConstants.BANCO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -15,6 +16,7 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaPatrimonioRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java index 97b8d7e..d6ab8b0 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientFactory.java @@ -2,11 +2,13 @@ import br.edu.ifrn.conta.dto.DonoDTO; import java.util.Optional; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class DonoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java index 2cf61ae..4963d5c 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java @@ -3,6 +3,7 @@ import br.edu.ifrn.conta.ContaApplication; import br.edu.ifrn.conta.dto.DonoDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -14,6 +15,7 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class DonoRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java index 0da4cdc..94ff07d 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.LancamentoDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class LancamentoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java index 7db3195..0e6a121 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java @@ -11,6 +11,7 @@ import java.time.LocalDateTime; import static org.assertj.core.api.Assertions.assertThat; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -20,6 +21,7 @@ import org.springframework.boot.test.context.SpringBootTest; import org.springframework.test.context.junit.jupiter.SpringExtension; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class LancamentoRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java index 7f49c05..2bc40ad 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.LancamentoDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class SaldoRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java index f0a68b8..eff54d2 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java @@ -18,6 +18,7 @@ import java.time.LocalDateTime; import static org.assertj.core.api.Assertions.assertThat; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -28,6 +29,7 @@ import org.springframework.test.context.junit.jupiter.SpringExtension; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class SaldoRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java index 7b3ddaa..5a79b05 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.TransferenciaDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class TransferenciaRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java index 606d14c..336da54 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java @@ -12,6 +12,7 @@ import java.math.BigDecimal; import static org.assertj.core.api.Assertions.assertThat; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -22,6 +23,7 @@ import org.springframework.test.context.junit.jupiter.SpringExtension; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class TransferenciaRestClientIT { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java index d32c7db..5137c3d 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientFactory.java @@ -1,11 +1,13 @@ package br.edu.ifrn.conta.restclient; import br.edu.ifrn.conta.dto.ValorInicialDoDonoNaContaPatrimonioDTO; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import lombok.experimental.SuperBuilder; import lombok.Data; import org.springframework.web.client.RestTemplate; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @SuperBuilder @Data public class ValorInicialDoDonoNaContaPatrimonioRestClientFactory { diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java index f06cdb6..162a50b 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java @@ -8,6 +8,7 @@ import static br.edu.ifrn.conta.util.ContaPatrimonioConstants.POUPANCA; import static br.edu.ifrn.conta.util.DonoConstants.MAMAE; +import edu.umd.cs.findbugs.annotations.SuppressFBWarnings; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.extension.ExtendWith; @@ -19,6 +20,7 @@ import static org.assertj.core.api.Assertions.assertThat; +@SuppressFBWarnings({"EI_EXPOSE_REP", "EI_EXPOSE_REP2"}) @ExtendWith(SpringExtension.class) @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ValorInicialDoDonoNaContaPatrimonioRestClientIT { From 6b91a007b5ab8383ecb8bbd00f3a5a70553b467b Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Thu, 25 Apr 2024 17:13:58 +0000 Subject: [PATCH 5/7] fix SS_SHOULD_BE_STATIC spotbugs errors just skipping the error with annotations. --- .../br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java | 4 ++-- .../edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java | 4 ++-- .../br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java | 4 ++-- .../ifrn/conta/restclient/ContaPatrimonioRestClientIT.java | 4 ++-- .../java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java | 4 ++-- .../br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java | 4 ++-- .../java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java | 4 ++-- .../edu/ifrn/conta/restclient/TransferenciaRestClientIT.java | 4 ++-- .../ValorInicialDoDonoNaContaPatrimonioRestClientIT.java | 4 ++-- 9 files changed, 18 insertions(+), 18 deletions(-) diff --git a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java index 970f823..9b083c2 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/CategoriaRestClientIT.java @@ -20,8 +20,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class CategoriaRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java index a5c6a98..1cf6976 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaCreditoRestClientIT.java @@ -21,8 +21,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaCreditoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java index 4fed2c7..543bbcf 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaDebitoRestClientIT.java @@ -21,8 +21,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaDebitoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java index a5a6aaf..be918de 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ContaPatrimonioRestClientIT.java @@ -21,8 +21,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ContaPatrimonioRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java index 4963d5c..3b547c5 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/DonoRestClientIT.java @@ -20,8 +20,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class DonoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java index 0e6a121..8710f7e 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/LancamentoRestClientIT.java @@ -26,8 +26,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class LancamentoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java index eff54d2..d517117 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/SaldoRestClientIT.java @@ -34,8 +34,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class SaldoRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java index 336da54..ba69d88 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/TransferenciaRestClientIT.java @@ -28,8 +28,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class TransferenciaRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; diff --git a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java index 162a50b..221ec87 100644 --- a/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java +++ b/src/test/java/br/edu/ifrn/conta/restclient/ValorInicialDoDonoNaContaPatrimonioRestClientIT.java @@ -25,8 +25,8 @@ @SpringBootTest(classes = ContaApplication.class, webEnvironment = SpringBootTest.WebEnvironment.RANDOM_PORT) public class ValorInicialDoDonoNaContaPatrimonioRestClientIT { - private final String protocol = "http"; - private final String servername = "localhost"; + private static final String protocol = "http"; + private static final String servername = "localhost"; @Value(value = "${local.server.port}") private int port; From ccceabeb9aa81091c1505d7503ca2034efa82090 Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Thu, 25 Apr 2024 17:15:36 +0000 Subject: [PATCH 6/7] add spotbugs to pipeline --- .github/workflows/maven.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml index 0815d82..8d3de14 100644 --- a/.github/workflows/maven.yml +++ b/.github/workflows/maven.yml @@ -34,5 +34,8 @@ jobs: - name: Validate run: ./mvnw -B clean validate + - name: Check spotbugs + run: ./mvnw -B -DskipTests=true -P check-spotbugs verify + - name: Tests run: ./mvnw -B -DwebDriverType=chrome verify From 79178457c51bb44cb5d5e7a3fb1a2dcf9ac43c4d Mon Sep 17 00:00:00 2001 From: Marcelo Romulo Fernandes Date: Thu, 25 Apr 2024 17:28:20 +0000 Subject: [PATCH 7/7] fix tests errors --- src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java | 5 +++++ .../java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java b/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java index 6de8721..05088a8 100644 --- a/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java +++ b/src/test/java/br/edu/ifrn/conta/persistence/DonoFactory.java @@ -6,6 +6,7 @@ import br.edu.ifrn.conta.domain.Dono; import static br.edu.ifrn.conta.util.DonoConstants.MAMAE; import static br.edu.ifrn.conta.util.DonoConstants.PAPAI; +import static br.edu.ifrn.conta.util.DonoConstants.TITIA; import java.util.Optional; @Component @@ -31,4 +32,8 @@ public Dono papai() { public Dono mamae() { return dono(MAMAE); } + + public Dono titia() { + return dono(TITIA); + } } diff --git a/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java b/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java index db939e9..4919c1b 100644 --- a/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java +++ b/src/test/java/br/edu/ifrn/conta/persistence/DonoRepositoryIT.java @@ -49,11 +49,12 @@ public void countByDescricao() { // cria o ambiente de teste this.donoFactory.papai(); this.donoFactory.mamae(); + this.donoFactory.titia(); // executa a operacao a ser testada // verifica o efeito da execucao da operacao a ser testada assertThat(this.donoRepository.countByDescricaoContains("a")) - .isEqualTo(2); + .isEqualTo(3); } @Test