From b1c3ed4a39bb7442118faff4dcd27223f0350f6b Mon Sep 17 00:00:00 2001 From: JCGuerrero Date: Sat, 11 Oct 2025 10:17:01 -0500 Subject: [PATCH 1/5] f --- .github/workflows/always.yml | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/.github/workflows/always.yml b/.github/workflows/always.yml index 42ba5c0..ea2ecb0 100644 --- a/.github/workflows/always.yml +++ b/.github/workflows/always.yml @@ -4,23 +4,8 @@ on: workflow_dispatch: # Allows you to run this workflow manually from the Actions tab jobs: - # TODO move me to common - # SRC https://medium.com/attest-product-and-technology/adding-a-unique-github-build-identifier-7aa2e83cadca - id: - name: Build Id - runs-on: ubuntu-latest - steps: - - name: id - id: id - run: echo "BUILD_ID=$(date +%s)" >> $GITHUB_ENV - - - name: echo - run: echo ${{ env.BUILD_ID }} - - test: name: npm test - needs: id runs-on: ubuntu-latest steps: - uses: percebus/github-actions-common/.github/actions/checkout@main @@ -44,7 +29,7 @@ jobs: tests: - if: github.ref == 'refs/heads/main' + # if: github.ref == 'refs/heads/main' # FIXME needs: test strategy: fail-fast: false @@ -60,6 +45,7 @@ jobs: - 21 - 22 - 23 + - 24 os: - ubuntu-latest - macOS-latest From f7ed33cff8ec640bc4af470f11a4ed2833375cf5 Mon Sep 17 00:00:00 2001 From: JCGuerrero Date: Sat, 11 Oct 2025 10:26:21 -0500 Subject: [PATCH 2/5] t2 --- .github/workflows/always.yml | 19 ++++++++++--------- __tests__/NaN/NaN.unit.spec.js | 12 ++++-------- __tests__/Object/Array/Array.unit.spec.js | 12 ++++-------- __tests__/Object/Object/Object.unit.spec.js | 6 ++---- __tests__/nothing/null.unit.spec.js | 8 +++----- __tests__/nothing/undefined.unit.spec.js | 12 ++++-------- 6 files changed, 27 insertions(+), 42 deletions(-) diff --git a/.github/workflows/always.yml b/.github/workflows/always.yml index ea2ecb0..c6d8bcc 100644 --- a/.github/workflows/always.yml +++ b/.github/workflows/always.yml @@ -36,16 +36,17 @@ jobs: max-parallel: 6 matrix: node: - - '' # default (LTS) - - 16 - - 17 - - 18 - - 19 - - 20 - - 21 - - 22 - - 23 + # - 16 + # - 17 + # - 18 + # - 19 + # - 20 + # - 21 + # - 22 + # - 23 - 24 + - '' # default (20 as of 2025-10-11) + - lts # 22 as of 2025-10-11 os: - ubuntu-latest - macOS-latest diff --git a/__tests__/NaN/NaN.unit.spec.js b/__tests__/NaN/NaN.unit.spec.js index d485748..5edf033 100644 --- a/__tests__/NaN/NaN.unit.spec.js +++ b/__tests__/NaN/NaN.unit.spec.js @@ -13,16 +13,12 @@ describe('NaN', () => { }) describe('lodash', () => { - describe('_.isNaN(NaN)', () => { - it('is', () => { - expect(_.isNaN(NaN)).toBe(true) - }) + it('_.isNaN', () => { + expect(_.isNaN(NaN)).toBe(true) }) - describe('_.isNumber(NaN)', () => { - it('is', () => { - expect(_.isNumber(NaN)).toBe(true) - }) + it('_.isNumber', () => { + expect(_.isNumber(NaN)).toBe(true) }) }) diff --git a/__tests__/Object/Array/Array.unit.spec.js b/__tests__/Object/Array/Array.unit.spec.js index 3e34592..3265d72 100644 --- a/__tests__/Object/Array/Array.unit.spec.js +++ b/__tests__/Object/Array/Array.unit.spec.js @@ -63,16 +63,12 @@ describe('Array', () => { }) describe('lodash', () => { - describe('_.isObject', () => { - it('is', () => { - expect(_.isObject(emptyArray)).toBe(true) - }) + it('_.isObject', () => { + expect(_.isObject(emptyArray)).toBe(true) }) - describe('_.isArray', () => { - it('is', () => { - expect(_.isArray(emptyArray)).toBe(true) - }) + it('_.isArray', () => { + expect(_.isArray(emptyArray)).toBe(true) }) }) }) diff --git a/__tests__/Object/Object/Object.unit.spec.js b/__tests__/Object/Object/Object.unit.spec.js index 39f30f6..b71a75f 100644 --- a/__tests__/Object/Object/Object.unit.spec.js +++ b/__tests__/Object/Object/Object.unit.spec.js @@ -34,10 +34,8 @@ describe('Object', () => { }) describe('lodash', () => { - describe('_.isObject', () => { - it('is', () => { - expect(_.isObject(emptyObject)).toBe(true) - }) + it('_.isObject', () => { + expect(_.isObject(emptyObject)).toBe(true) }) describe('_.isArray', () => { diff --git a/__tests__/nothing/null.unit.spec.js b/__tests__/nothing/null.unit.spec.js index 001484a..995d5a9 100644 --- a/__tests__/nothing/null.unit.spec.js +++ b/__tests__/nothing/null.unit.spec.js @@ -13,7 +13,7 @@ describe('null', () => { }) describe('Number', () => { - describe('isNaN(null)', () => { + describe('isNaN', () => { it('is NOT', () => { expect(isNaN(null)).toBe(false) }) @@ -21,10 +21,8 @@ describe('null', () => { }) describe('lodash', () => { - describe('_.isNull(null)', () => { - it('is', () => { - expect(_.isNull(null)).toBe(true) - }) + it('_.isNull', () => { + expect(_.isNull(null)).toBe(true) }) }) diff --git a/__tests__/nothing/undefined.unit.spec.js b/__tests__/nothing/undefined.unit.spec.js index 27a594d..e8a9a5d 100644 --- a/__tests__/nothing/undefined.unit.spec.js +++ b/__tests__/nothing/undefined.unit.spec.js @@ -6,10 +6,8 @@ describe('undefined', () => { }) describe('Number', () => { - describe('isNaN(undefined)', () => { - it('is', () => { - expect(isNaN(undefined)).toBe(true) - }) + it('isNaN(undefined)', () => { + expect(isNaN(undefined)).toBe(true) }) }) @@ -24,10 +22,8 @@ describe('undefined', () => { }) describe('lodash', () => { - describe('_.isUndefined(undefined)', () => { - it('is', () => { - expect(_.isUndefined(undefined)).toBe(true) - }) + it('_.isUndefined', () => { + expect(_.isUndefined(undefined)).toBe(true) }) }) From 7eefed0f1be0f6f9647eb91ee3dbe0780c5615a7 Mon Sep 17 00:00:00 2001 From: JCGuerrero Date: Sat, 11 Oct 2025 10:33:46 -0500 Subject: [PATCH 3/5] ff --- .github/workflows/always.yml | 45 +++++++++++++++++++----------------- 1 file changed, 24 insertions(+), 21 deletions(-) diff --git a/.github/workflows/always.yml b/.github/workflows/always.yml index c6d8bcc..54cf6e3 100644 --- a/.github/workflows/always.yml +++ b/.github/workflows/always.yml @@ -6,17 +6,21 @@ on: jobs: test: name: npm test - runs-on: ubuntu-latest - steps: - - uses: percebus/github-actions-common/.github/actions/checkout@main - - uses: percebus/github-actions-node/.github/actions/setup@main - - uses: percebus/github-actions-npm/.github/actions/install@main + uses: percebus/github-actions-npm/.github/workflows/test.yml@main + with: + list-tests: all - - name: npm test - run: npm test - - uses: percebus/github-actions-testing/.github/actions/junit@main - with: - list-tests: all + # runs-on: ubuntu-latest + # steps: + # - uses: percebus/github-actions-common/.github/actions/checkout@main + # - uses: percebus/github-actions-node/.github/actions/setup@main + # - uses: percebus/github-actions-npm/.github/actions/install@main + + # - name: npm test + # run: npm test + # - uses: percebus/github-actions-testing/.github/actions/junit@main + # with: + # list-tests: all testem: @@ -29,24 +33,23 @@ jobs: tests: - # if: github.ref == 'refs/heads/main' # FIXME + if: github.ref == 'refs/heads/main' needs: test strategy: fail-fast: false max-parallel: 6 matrix: node: - # - 16 - # - 17 - # - 18 - # - 19 - # - 20 - # - 21 - # - 22 - # - 23 - - 24 - '' # default (20 as of 2025-10-11) - - lts # 22 as of 2025-10-11 + - 16 + - 17 + - 18 + - 19 + - 20 + - 21 + - 22 + - 23 + - 24 os: - ubuntu-latest - macOS-latest From 4b604c178efeb9f74017406acf73950c62c7efca Mon Sep 17 00:00:00 2001 From: JCGuerrero Date: Sat, 11 Oct 2025 10:39:36 -0500 Subject: [PATCH 4/5] r --- .github/workflows/always.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/always.yml b/.github/workflows/always.yml index 54cf6e3..47ce480 100644 --- a/.github/workflows/always.yml +++ b/.github/workflows/always.yml @@ -8,6 +8,8 @@ jobs: name: npm test uses: percebus/github-actions-npm/.github/workflows/test.yml@main with: + reporter: jest-junit + files_pattern: junit.xml list-tests: all # runs-on: ubuntu-latest @@ -69,6 +71,6 @@ jobs: run: npm test - uses: percebus/github-actions-testing/.github/actions/junit@main with: - tests_name: Unit Tests @ node:${{ matrix.node }}@${{ matrix.os }} + tests_name: Tests Results @ node:${{ matrix.node }}@${{ matrix.os }} summary_title: "" publish-test-deltas: "false" From 5a0b694c47c0e3d16de36f516002908f19b09d5f Mon Sep 17 00:00:00 2001 From: JCGuerrero Date: Sat, 11 Oct 2025 10:42:36 -0500 Subject: [PATCH 5/5] fff --- .github/workflows/always.yml | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/.github/workflows/always.yml b/.github/workflows/always.yml index 47ce480..8415c7b 100644 --- a/.github/workflows/always.yml +++ b/.github/workflows/always.yml @@ -12,18 +12,6 @@ jobs: files_pattern: junit.xml list-tests: all - # runs-on: ubuntu-latest - # steps: - # - uses: percebus/github-actions-common/.github/actions/checkout@main - # - uses: percebus/github-actions-node/.github/actions/setup@main - # - uses: percebus/github-actions-npm/.github/actions/install@main - - # - name: npm test - # run: npm test - # - uses: percebus/github-actions-testing/.github/actions/junit@main - # with: - # list-tests: all - testem: if: false # FIXME not working @@ -57,6 +45,7 @@ jobs: - macOS-latest - windows-latest + # uses: percebus/github-actions-npm/.github/workflows/test.yml@main # TODO when it accepts node version runs-on: ${{ matrix.os }} name: npm test @ node:${{ matrix.node }}@${{ matrix.os }} steps: