Creating action with undefined payload converts to {}

[mischkl]

I just ran into this issue after upgrading to 2.x, which has caused a serious bug in our application.

Using an action creator without specifying a payload, for an action that expects a payload (created with typeOf), results in the payload being "autogenerated" as the empty object {}. This is a serious issue because sometimes we want to pass on the fact that there is no value being passed.

We managed to work around the issue by converting to null when calling the action creator, e.g. MyActionType.DoSomething(value || null). However this seems to be an unnecessary burden for developers to always have to do this.

[pelotom]

Can you provide a full, self-contained code snippet to illustrate what you mean? I'm not sure I follow.

[mischkl]

Hi, sorry for the delayed response.

Here is an example:

// actions
export const UserActions = unionize({
  GetAllUsers: {},
  GetAllUsersSuccess: ofType<User[]>(),
  SelectUser: ofType<string>()
}, {tag: 'type', value: 'payload'});

// use of action creator
const selectedUser = getLoggedInUser(); // returns undefined
const selectAction = UserActions.SelectUser(selectedUser);
// creates { type: 'SelectUser', payload: {} }
// expected behavior: { type: 'SelectUser', payload: undefined }