getAllAsModel ignores filters

[Drachenkaetzchen]

I try to retrieve all clients matching a given email address, so I don't create duplicate clients by accident:

$client = new Client();
$client->setFilter(array("email" => "example@example.com"));

$response = $request->getAllAsModel($client);

However, the getAllAsModel() call returns all clients and ignores the filter.

If I change getAllAsModel to getAll, I receive the expected result.

[mgleis]

Same for Transaction objects :-(

Solution: add the following code to the request classes in \Paymill\Models\Request*

        case 'getAll':
        case 'getAllAsModel':    // <-- this line is new
            $parameterArray = $this->getFilter();
            break;

Please add this ;-)

[mgleis]

Workaround until bug is fixed: call getAll and convert yourself:

$client = new Client(); 
$client->setFilter(array("email" => "example@example.com"));
$response = $request->getAll($client);
$clients = [];
foreach ($response as $entry) {
    $clients[] = $r->convertResponse($entry, $client->getServiceResource());
}

[danielsippel]

+1