Add a way to set the application icon

[binaryfire]

The PHP logo is showing up as the app icon in Windows:

I'm not sure what happens on macOS and various Linux distros, but I think most OSes support app icons. It'd be great if there was a way of defining these in PHPacker.

The default icon should be something generic like this: https://thenounproject.com/browse/icons/term/command-line/. That would be suitable for most cli tools.

[gwleuverink]

This would be a cool addition if it is possible. I need to do some digging though. I assume the icon needs to be encoded in the file. Any icon changes to a file like this will not be portable on mac (need to verify)

[gwleuverink]

I converted this to a discussion in the meantime @binaryfire 👍🏻

[binaryfire]

From what I understand, this is only an issue for Windows. I don't think Mac or Linux binaries have icons embedded directly into binaries in the same way. Need to confirm that though.

There's an option to use a custom icon for Windows but it seems to be broken at the moment: crazywhalecc/static-php-cli#669. Once it's fixed, I'll work on a PR to add a generic icon to the Windows builds. I think something like this will be fine for most people: https://www.iconarchive.com/show/ionicons-icons-by-ionic/terminal-icon.html

[gwleuverink]

Awesome! I had no idea micro supported that. Yeah let's, it would be a nice improvement adding to the feel of maturity of the project 💪🏻
I appreciate your input!

[binaryfire]

I don't have access to a Mac - could you let me know if your built cli apps show the PHP logo or a generic icon? A generic icon is fine for now IMHO. We can investigate ways of adding custom icons for Mac and Linux later. I think it would have to be done post-build for those OSes.

[gwleuverink]

On mac it looks like this by default:

[binaryfire]

Ah that’s great. So it’s only Windows where we need to add a generic icon like that manually.

[gwleuverink]

A relevant implementation detail just occurred to me. When installing a phpacker app using our custom composer installer we create Unix style proxy files to the correct executable. Similar to how composer handles executables natively.

If we add a windows icon it might be lost when installing your app with composer.

We’ll support more distribution methods in the future. This might not be an issue for homebrew or apt but I thought you should be aware of the installer behavior as it stands right now.

Phpacker itself uses this composer installer method. I wonder what it’s default icon in vendor/bin is on windows.

[binaryfire]

Good point. I checked vendor/phpacker/phpacker/bin/build/windows/windows-x64.exe and yeah, it has the PHP logo:

I just submitted a PR to php-bin adding a generic terminal icon for Windows. If the phpacker binaries are also using php-bin then won't it inherit the new logo too?

[gwleuverink]

@binaryfire I just released a new version including your PR 0.3.1.

[binaryfire]

Nice. Much better now!