Themes support

[pgilfernandez]

@rodlie,

Following our conversation about the new themes support from your theme-changes branch:

• changing "Timeline" into "Colors" or "Themes" as the exposed parameters there are colors and may be related with Themes
• use a select/new/delete/import/export set of spinbox+icons to manage themes
• I changed the "color button" square into a "by 4 width" one, easier to press and preview the color
• expose all theme colors there, indeed

[pgilfernandez]

I will probably suggest new names and/or colors when I'm able to play with the variables at Preferences as it would be hard now to know where some colors are used...

How are you imagining the theme color Preferences panel? something like I proposed?

[rodlie]

I will need to finish the Colors struct first, there are some changes to names and some new colors that needs to be added. Names ending with Sk will also be removed.

How are you imagining the theme color Preferences panel? something like I proposed?

Your mockup works.

[pgilfernandez]

Hi @rodlie,

Any progression on this side? you left it almost ready to add the variables into Preferences... right?

[rodlie]

Might still be some hard-coded colors left, and some names might need to change, don't remember🙂

This is a v1.1 feature so not the highest priority from my pov, but feel free to fix/improve, we can always change names etc later. I might have some time to check the status this weekend.

[pgilfernandez]

Yes, I know it's v1.1 but feel like helping in this subject and wanted to know if I could continue the work while you focus on v1.0.

BTW, may it need a rebase? You made some changes lately, doesn't it?

[rodlie]

if I could continue the work while you focus on v1.0.

Sure 👍

BTW, may it need a rebase? You made some changes lately, doesn't it?

I merged main into theme-changes a couple of hours ago.

[pgilfernandez]

Awesome!
Tomorrow I'll start playing with it 😁

Thanks!