Skip to content
This repository was archived by the owner on Apr 6, 2022. It is now read-only.
This repository was archived by the owner on Apr 6, 2022. It is now read-only.

Include video durations in estimatedConsumptionMinutes #273

@tpreusse

Description

@tpreusse

Bug Report

Steps to Reproduce

{
  document(path: "/2019/06/08/das-verlorene-paradies") {
    meta {
      totalMediaMinutes
      estimatedReadingMinutes
      estimatedConsumptionMinutes
    }
    content
  }
}

Live Query

Additional issue: if content is not requested totalMediaMinutes is 0 because it's resolved at request time.

Actual Results

{
  "data": {
    "document": {
      "meta": {
        "totalMediaMinutes": 19,
        "estimatedReadingMinutes": 4,
        "estimatedConsumptionMinutes": 4
      },
      "content": {} // clipped
  }
}

Expected Results

{
  "data": {
    "document": {
      "meta": {
        "totalMediaMinutes": 19,
        "estimatedReadingMinutes": 4,
        "estimatedConsumptionMinutes": 23
      },
      "content": {} // clipped
  }
}

Possible Solutions

  • preprocess totalMediaMinutes at index time
  • add totalMediaMinutes to estimatedConsumptionMinutes unless meta.audioSource.durationMs is present
    • this should still win for e.g. «An der Bar» cases where there is a video and audio file of the same thing and same duration

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions